fix: handle tool messages in last round loss scaling - #9923
Merged
tastelikefeet merged 3 commits intoAug 16, 2026
Conversation
tastelikefeet
approved these changes
Aug 16, 2026
Collaborator
|
Hi, can you lint the code via 'pre-commit run --all-files' please? |
Contributor
Author
Thanks for the reminder. I ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Fix incorrect
last_roundloss scaling for agent conversations containing tool responses.Previously,
get_last_user_roundonly recognized messages with theuserrole. In tool-call conversations, atoolmessage starts the final query-response round, so the last round could be identified incorrectly and loss scaling could be applied to earlier assistant responses.This change treats both
userandtoolmessages as valid round-start messages. It also adds a regression test for a conversation ending with a tool response followed by the final assistant response.Experiment results
tests/loss_scale/test_last_user_round.pygit diff --checkpassed.