fix(runtime): make AudioFrame copies own their sample data - #3450
Open
wangxiuwen wants to merge 1 commit into
Open
fix(runtime): make AudioFrame copies own their sample data#3450wangxiuwen wants to merge 1 commit into
wangxiuwen wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Complete
AudioFrame's copy ownership semantics:global_startandglobal_endmetadata.Why is this needed?
AudioFrameownsdataand releases it in its destructor. The existing copy constructor copied only part of the metadata and silently dropped the sample buffer. The implicit copy-assignment operator was more dangerous: it shallow-copied the owned pointer, allowing two frames to free the same allocation.Implementing both copy operations keeps the existing copyable API while giving each frame independent ownership of its samples.
Validation
git diff --checkAudioFramecopy operations are not currently used by the in-tree runtime call sites, so this does not change hot-path behavior.