fix(runtime): prevent leaks in two-pass timestamp inference - #3448
Open
wangxiuwen wants to merge 1 commit into
Open
fix(runtime): prevent leaks in two-pass timestamp inference#3448wangxiuwen wants to merge 1 commit into
wangxiuwen wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix two ownership leaks in the timestamp pass of
FunTpassInferBuffer:AudioFramebefore the empty-result earlycontinue.Why is this needed?
The input arrays were allocated with
new[]on every timestamp-pass iteration and were never released. In addition, whenSplitStrreturned no fields, control skipped the existing frame cleanup at the end of the loop.Both leaks accumulate while processing two-pass streaming audio. The stack arrays have the same lifetime required by the synchronous
Forwardcall and require no ownership management.Validation
git diff --checkForwardoverloads still receive the same one-element pointer and length arrays.