Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #360. Adds iOS to
screen.on('dialog').Detection
mobilecli's iOS tree shows both app alerts and system permission prompts (from SpringBoard) as an
Alertnode:label= title, flat children = title and messageStaticTexts, an optionalTextField, andButtons.promptif there's a TextField,confirmif more than one button, otherwisealert“Playground” would like to access the Camera.). A locale that quotes differently reads as an app alert.WDA instead always uses last = accept and first = dismiss, which would tap "Don't Allow" when accepting the iOS location prompt.
accept(text)now finds the OK button again by re-detecting the dialog, so it works on both platforms (iOS buttons have no ids).e2e
e2e/src/android/dialogs.test.ts→e2e/src/dialogs/dialogs.test.ts, which now runs on both platforms:getByTestIdFormonly lists rendered rowsKnown gap
On iOS simulators,
clearAppData()doesn't reset permissions. Today that needssimctl privacy reset all <bundle>, and notifications only reset on reinstall. The e2e permission tests therefore need a fresh install on iOS. Documented in the guide.Test plan