feat: publish CLI binaries with releases and add --version - #3
Merged
Merged
Conversation
A release now attaches the appmeta CLI for macOS and Linux, on arm64 and amd64, each as appmeta-<version>-<os>-<arch>.zip. The release version is set in the binary at build time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares v1.0.1.
Release assets: the
releasejob cross-compiles the CLI and attaches four zips, named as mobilecli's are:appmeta-1.0.1-macos-arm64.zipappmeta-1.0.1-macos-amd64.zipappmeta-1.0.1-linux-arm64.zipappmeta-1.0.1-linux-amd64.zipEach holds a single
appmetabinary, built withCGO_ENABLED=0,-trimpathand-s -w.appmeta --version: printsappmeta version <version>. The workflow sets it with-ldflags -X main.version; local builds printdev. The flag has no short form.CHANGELOG: adds the 1.0.1 section the release notes are taken from.
Notes for the reviewer
Test plan
go vet ./...andgo test -race ./...GITHUB_REF_NAME=v1.0.1: four zips produced, and the macOS arm64 binary printsappmeta version 1.0.1v1.0.1and confirm the release has the four zips and the changelog notes