Conversation
Read failures and cancelled contexts now fail the parse instead of becoming warnings. MaxEntries is checked against the entries actually read, the zip64 lookup honours the directory size marker, and the APK signing block counts towards MaxTotalSize. Permission deduplication is linear, and brackets inside XML plist strings no longer count as nesting. Adds ErrMalformed and constants for the format, platform and signing values. The CLI reports a failed write of its output.
A vMAJOR.MINOR.PATCH tag creates a GitHub release whose notes are the matching section of CHANGELOG.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First version of appmeta: a Go library and CLI that extract metadata from Android
.apkand iOS.ipafiles.Parse/ParseContextread through anio.ReaderAt, touching only the zip central directory and the entries they need. Input is treated as hostile: every read is bounded byLimits, and panics become errors.resources.arsclookups for label and icon, adaptive icon foreground, native ABIs, debug vs release signing (v1, v2, v3, v3.1).Info.plist(binary and XML), CgBI icons, Mach-O architectures and simulator detection, provisioning profile.appmeta <app.apk|app.ipa>prints JSON matchingschema/appmeta.schema.json.MaxEntriesis checked against the entries actually read; the APK signing block counts towardsMaxTotalSize; permission deduplication is linear; brackets inside XML plist strings are not counted as nesting. AddsErrMalformedand constants for format, platform and signing values.vMAJOR.MINOR.PATCHtag creates a GitHub release with notes taken fromCHANGELOG.md.Notes for the reviewer
GITHUB_TOKENwithcontents: write.pull_requestis kept so fork PRs are checked.go.moddeclaresgo 1.26.0, and cobra lives in the library's module. Both affect importers and are not changed here.Test plan
go vet ./...go test -race -cover ./...— 85.6% library, 59.4% CLIFuzzParse,FuzzPlist,FuzzAPKSigninggolangci-lint(not installed locally; runs in CI)v1.0.0and confirm the release is created with the changelog notes