Enable RBAC support + sorted hashes - #50
Open
cc32d9 wants to merge 7 commits into
Open
Conversation
This patch enables the RBAC (Role Based Access Control) introduced from Couchbase Server 4.5.
```
--- xs/Couchbase.xs.orig Mon Jul 23 23:41:36 2018
+++ xs/Couchbase.xs Mon Jul 23 23:42:10 2018
@@ -36,6 +36,7 @@ PLCB_construct(const char *pkg, HV *hvopts)
PLCB_t *object;
plcb_OPTION options[] = {
PLCB_KWARG("connstr", CSTRING, &cr_opts.v.v3.connstr),
+ PLCB_KWARG("username", CSTRING, &cr_opts.v.v3.username),
PLCB_KWARG("password", CSTRING, &cr_opts.v.v3.passwd),
PLCB_KWARG("io", SV, &iops_impl),
PLCB_KWARG("on_connect", CV, &conncb),
```
Synopsis
The xs/Couchbase.xs is already patched in this commit.
Just compile and install as usual:
perl Makerfile.PL
make
make install
Contributors
ABS - https://github.com/abiscuola
Hannibal - https://github.com/annibale-x
This patch enables the RBAC (Role Based Access Control) introduced from Couchbase Server 4.5.
--- xs/Couchbase.xs.orig Mon Jul 23 23:41:36 2018
+++ xs/Couchbase.xs Mon Jul 23 23:42:10 2018
@@ -36,6 +36,7 @@ PLCB_construct(const char *pkg, HV *hvopts)
PLCB_t *object;
plcb_OPTION options[] = {
PLCB_KWARG("connstr", CSTRING, &cr_opts.v.v3.connstr),
+ PLCB_KWARG("username", CSTRING, &cr_opts.v.v3.username),
PLCB_KWARG("password", CSTRING, &cr_opts.v.v3.passwd),
PLCB_KWARG("io", SV, &iops_impl),
PLCB_KWARG("on_connect", CV, &conncb),
INSTALLATION
The xs/Couchbase.xs is already patched in this commit.
Just compile and install the Perl module as usual:
perl Makerfile.PL
make
make install
NOTES
POD updated (only Couchbase/Bucket.pm)
CONTRIBUTORS
Andrea ABS - https://github.com/abiscuola
Hannibal - https://github.com/annibale-x
x-hannibal
approved these changes
Aug 9, 2019
x-hannibal
approved these changes
Aug 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets "canonical" mode in JSON encoder, so that all documents are created with sorted hashes. Otherwise Perl randomizes them and they are difficult to analyze.
Also this PR embraces Annibale's RBAC support.