Skip to content

Refactor win detection to use a configurable winningValue #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmiermans wants to merge 1 commit into
base: exp/mozilla-base
Choose a base branch
from
Open

Refactor win detection to use a configurable winningValue #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions webclient/public/js/game_manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ function GameManager(size, InputManager, Actuator, bootFeed) {
this.inputManager = new InputManager;

this.startTiles = 2;
this.winningValue = 2048; // Tile value that wins the game

this.inputManager.on("nextGame", this.nextGame.bind(this));

Expand Down Expand Up @@ -352,7 +353,7 @@ GameManager.prototype.move = function (direction) {
self.bestScore = Math.max(self.bestScore, self.score);

// The mighty 2048 tile
if (merged.value === 2048) self.won = true;
if (merged.value > self.winningValue) self.won = true;
} else {
self.moveTile(tile, positions.farthest);
}
Expand Down Expand Up @@ -459,14 +460,9 @@ GameManager.prototype.getMaxTile = function() {
return maxTile;
}

// Determine whether a tile of value >= 2048 exists
// Determine whether a winning tile exists on the grid
GameManager.prototype.hasWon = function () {
this.grid.eachCell(function (x, y, tile) {
if (tile && tile >= 2048) {
return true;
}
});
return false;
return this.getMaxTile() >= this.winningValue;
};

GameManager.prototype.positionsEqual = function (first, second) {
Expand Down
Loading