Conversation
-lversion now prints 'late 2.0.0-rc.1 (build N, commit X, built DATE)' so every build is uniquely identifiable — no more identical static version strings. Build number is git rev-list --count HEAD (deterministic, monotonic, offline; 'unknown' outside a git tree). The info bar shows the compact form 'v2.0.0-rc.1 · bN · <commit>'. Makefile and both install-dev.sh direct-build paths stamp all three via -ldflags -X.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-versionused to print a static string identical across every build — two binaries built a month apart were indistinguishable. Now it printsso every build is uniquely identifiable.
How it's stamped
git rev-list --count HEAD— deterministic, monotonic, works offline; reportsunknownoutside a git treeThe Makefile stamps all three via
-ldflags -X, with a graceful fallback when git isn't available, and unknown pieces are omitted from the display instead of printed as noise.Scope notes
v2.0.0-rc.1 · bN · <commit>form) rides with the info-bar PR — there's no info bar on main yetTesting
exit 0 — all 18 packages green (15 ok, 3 without test files).