You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There have been now some more changes, but overall I feel final to merge back.
The PR now contains a change to the main countries.json introducing a unique id for every country (ucid) to allow for updating the countries in a database.
Hello, thank you for your work, I will look into it this week.
Thanks a lot for your work and idea on this repository, it did help me very much with getting a good head start.
If you need changes or input I would be very happy and glad to provide them.
For the necessary change adding a unique country _id, it would be very nice to have your insight if there would be another approach possible instead of using an ordinal number. I did thought about the country code but as this is not provided for all countries it was not a good fit. Any other value seemed to be not constant and subjected to change or it felt not a good fit as a unique database ID at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two converters for SQL inserts and updates