Skip to content

Cache key can handle nested dicts #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkorycki merged 1 commit into from
Jun 11, 2026
Merged

Cache key can handle nested dicts #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/modelplane/evaluator/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import json
from dataclasses import dataclass, field
from typing import Any, Optional

Expand Down Expand Up @@ -123,7 +124,7 @@ def with_updates(
)

def hash(self):
return hash((self.prompt, self.response, frozenset(self.metadata.items())))
return hash((self.prompt, self.response, json.dumps(self.metadata, sort_keys=True, separators=(',', ':'), ensure_ascii=False)))

def __eq__(self, value: EvalContext) -> bool:
if not isinstance(value, EvalContext):
Expand Down
19 changes: 19 additions & 0 deletions tests/unit/evaluator/test_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,3 +87,22 @@ def test_hash(sample_ctx):
metadata={"key": "value"},
)
assert sample_ctx.hash() != other_ctx.hash()

# Make sure can handle nested dictionaries in metadata
nested_ctx_1 = EvalContext(
prompt=sample_ctx.prompt,
response=sample_ctx.response,
metadata={"key": "value", "nested": {"key": "value_1"}},
)
nested_ctx_2 = EvalContext(
prompt=sample_ctx.prompt,
response=sample_ctx.response,
metadata={"key": "value", "nested": {"key": "value_2"}},
)
nested_ctx_2_copy = EvalContext(
prompt=sample_ctx.prompt,
response=sample_ctx.response,
metadata={"key": "value", "nested": {"key": "value_2"}},
)
assert nested_ctx_1.hash() != nested_ctx_2.hash()
assert nested_ctx_2_copy.hash() == nested_ctx_2.hash()
Loading