Repository navigation
Fix panic when updating properties of a missing layer - #195
Merged
mkrueger merged 1 commit intoOct 27, 2026
Merged
Conversation
mkrueger
approved these changes
Oct 27, 2026
Contributor
Author
|
Thanks for reviewing and merging the fix. I appreciate your time and help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EditState::update_layer_propertiesindexeslayers[layer]after checks that allow a missing index through. A stale index,usize::MAX, or an empty buffer therefore panics instead of returning an error. This affects both locked and unlocked property requests.Check that the target exists before starting an undo group or building an undo operation. Add tests for invalid indices, an empty buffer, preserving the existing redo branch, and valid lock changes remaining undoable. No dependency or UI behavior change is included.
Validation on Windows / Rust 1.96: before the fix, two regression tests panic at layer_operations.rs:843 and the valid-operation control passes. After the fix, all three new tests and all 43 existing layer-operation tests pass. The existing test file was run unchanged through an isolated Cargo harness against the local patched crates with default features disabled; the full workspace suite has not been run locally. rustfmt and git diff --check pass. Upstream CI remains to be checked.
AI-assisted investigation and implementation with Codex.