Update typescript-eslint monorepo to v8 - #25
Conversation
b6e1bcd to
65fd708
Compare
65fd708 to
0fbc61b
Compare
ff500aa to
731b830
Compare
4ace2eb to
9c8c202
Compare
084fab7 to
facbbfc
Compare
c304df0 to
bbc8050
Compare
bbc8050 to
8e3d74a
Compare
| "@types/react": "^18.0.26", | ||
| "@types/react-addons-linked-state-mixin": "^0.14.22", |
There was a problem hiding this comment.
Bug: The project's ESLint configuration uses the eslintConfig key in package.json, which is no longer supported in ESLint v9, causing linting and CI builds to fail.
Severity: CRITICAL
Suggested Fix
Migrate the ESLint configuration from the eslintConfig property in package.json to the new flat config format by creating an eslint.config.js file in the affected package directories.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: ol-jupyter-authoring/package.json#L71-L72
Potential issue: The project uses ESLint v9, which has removed support for the legacy
`eslintConfig` property in `package.json`. Consequently, the existing ESLint
configuration will not be loaded when running linting scripts like `eslint:check`. This
will cause the CI build to fail in both the `ol-jupyter-authoring` and
`ol-themed-jupyter` packages, as ESLint will either error due to a missing configuration
or fall back to default rules, preventing code from being linted as intended.
Did we get this right? 👍 / 👎 to inform future reviews.
e3a5972 to
fb36703
Compare
| "@typescript-eslint/eslint-plugin": "^8.0.0", | ||
| "@typescript-eslint/parser": "^8.0.0", |
There was a problem hiding this comment.
Bug: The eslintConfig in package.json references the @typescript-eslint/quotes rule, which was removed in the upgraded @typescript-eslint/eslint-plugin v8, likely causing linting to fail.
Severity: MEDIUM
Suggested Fix
Since formatting rules were moved to @stylistic/eslint-plugin in typescript-eslint v7+, the reference to @typescript-eslint/quotes should be removed from the eslintConfig in package.json. To maintain the linting rule, add the @stylistic/eslint-plugin package and update the configuration to use the equivalent rule from that plugin, such as @stylistic/quotes.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: ol-jupyter-authoring/package.json#L73-L74
Potential issue: The project's ESLint configuration is defined in the `eslintConfig`
field of `package.json`. This configuration references the `@typescript-eslint/quotes`
rule. The pull request upgrades `@typescript-eslint/eslint-plugin` from v6 to v8, a
version in which this formatting rule was removed. If the `eslintConfig` field is
processed by ESLint v9, which is plausible for backward compatibility even though the
field is deprecated, the linting process will fail with a "rule not found" error. This
would break local development workflows and CI/CD pipelines that run the `eslint:check`
script.
7b15bf4 to
ca9cafa
Compare
ca9cafa to
1ceabf7
Compare
1ceabf7 to
fa43db6
Compare
cd2bf4f to
10fbce6
Compare
10fbce6 to
9eb238a
Compare
e3720fc to
e5a61c3
Compare
e5a61c3 to
f3908ba
Compare
f3908ba to
eb06444
Compare
07bab32 to
8cf6ba4
Compare
8cf6ba4 to
f9c90e8
Compare
68ed0e3 to
bf64b5c
Compare
9aabed9 to
f09dcac
Compare
b1f1603 to
fbf1786
Compare
fbf1786 to
426284e
Compare
2c08644 to
de7c64b
Compare
8640ccc to
a935524
Compare
a935524 to
682c0c9
Compare
There was a problem hiding this comment.
Pull request overview
Updates TypeScript ESLint tooling from v6 to v8 across both Jupyter extensions.
Changes:
- Upgrades the ESLint plugin and parser.
- Refreshes themed-extension transitive dependencies.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ol-themed-jupyter/package.json |
Updates TypeScript ESLint dependencies. |
ol-themed-jupyter/yarn.lock |
Locks upgraded dependency graph. |
ol-jupyter-authoring/package.json |
Updates TypeScript ESLint dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "@types/react-addons-linked-state-mixin": "^0.14.22", | ||
| "@typescript-eslint/eslint-plugin": "^6.1.0", | ||
| "@typescript-eslint/parser": "^6.1.0", | ||
| "@typescript-eslint/eslint-plugin": "^8.0.0", |
| "@types/react-addons-linked-state-mixin": "^0.14.22", | ||
| "@typescript-eslint/eslint-plugin": "^6.1.0", | ||
| "@typescript-eslint/parser": "^6.1.0", | ||
| "@typescript-eslint/eslint-plugin": "^8.0.0", |
This PR contains the following updates:
^6.1.0→^8.0.0^6.1.0→^8.0.0Release Notes
typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)
v8.67.0Compare Source
This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.66.0Compare Source
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.65.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.64.0Compare Source
🚀 Features
using/await usingdeclarations and deprecate the rule (#12500)🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.63.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.62.1Compare Source
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.62.0Compare Source
🚀 Features
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.61.1Compare Source
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.61.0Compare Source
🚀 Features
UnaryExpression.prefixto alwaystrue(#12372)❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.60.1Compare Source
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.60.0Compare Source
This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.59.4Compare Source
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.59.3Compare Source
This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.59.2Compare Source
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.59.1Compare Source
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.59.0Compare Source
🚀 Features
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.58.2Compare Source
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.58.1Compare Source
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.58.0Compare Source
🚀 Features
🩹 Fixes
no-unnecessary-type-arguments(#12163)❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.57.2Compare Source
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.57.1Compare Source
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.57.0Compare Source
🚀 Features
🩹 Fixes
TypeOrValueSpecifierto prefer-promise-reject-errors (#12094)cookedwill benull(#11355)❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.56.1Compare Source
This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.56.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.55.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.54.0Compare Source
🚀 Features
🩹 Fixes
def.name(#11982)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.53.1Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.53.0Compare Source
🚀 Features
🩹 Fixes
errortyped" with more helpful description (#11704)extendsandimplementsin interface declaration (#11935)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.52.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.51.0Compare Source
🚀 Features
🩹 Fixes
no-useless-default-assignment(#11845)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.50.1Compare Source
🩹 Fixes
this(#11813)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.50.0Compare Source
🚀 Features
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.49.0Compare Source
🚀 Features
Intl.Segmenterinstead ofgraphemer(#11804)🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.48.1Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.48.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.47.0Compare Source
🚀 Features
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.46.4Compare Source
🩹 Fixes
projectServiceandprojectare set (#11333)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.46.3Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.46.2Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.46.1Compare Source
🩹 Fixes
.finallynot to report when a promise returning function is provided as an argument (#11667)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.46.0Compare Source
🚀 Features
🩹 Fixes
export imports (#11603)this: voidand binding (#11634)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.45.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.44.1Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.44.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
[
v8.43.0](https://redirect.github.com/typescript-eslint/typescript-esConfiguration
📅 Schedule: (in timezone US/Eastern)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.