Optimizer changes#2
Open
cedriclim1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Bug fixes
OriginND was registered as a submodule of DiskTemplate, SyntheticDiskLattice, and GaussianBackground. Each component's optimizer included origin.coords, so the serial fit stepped it three times per iteration. Setting disk0.lr=0 and lat0.lr=0 zeroed
two updates, but gaussianbackground.lr=1e-5 kept moving the probe.
dict(self.optimizer_params) and dict(self.scheduler_params) in the infer*_rebuild_params helpers tried to iterate over OptimizerParams.Adam / SchedulerParams.Plateau dataclasses, which aren't iterable. This blocked set_component_trainable(...).
Files changed
quantem/src/quantem/core/fitting/base.py
set_independant_optimizer_params and rebuild_independant_optimizers handle "origin" too.
quantem/src/quantem/diffraction/model_fitting.py
Notebooks/20260511-multi-diff-batched.ipynb
Scripts/smoke_origin_freeze.py (new)
Public API
optimizer_params={"origin": {"type": "adamw", "lr": 0.0}} (and scheduler_params={"origin": {...}}) is the new way to control the probe origin across all components in both the serial and batched paths. When "origin" is omitted, LR falls back to the
first origin-owning component in priority order SyntheticDiskLattice > GaussianBackground > DiskTemplate, which preserves behavior for notebooks that previously relied on lat0.lr implicitly driving the probe.