Fix node digging grouops and sounds - #20
Open
Emojigit wants to merge 1 commit into
Open
Conversation
Sheriff-Unit-3
approved these changes
Jun 9, 2026
SmallJoker
reviewed
Jun 14, 2026
| is_ground_content = false, | ||
| groups = {cracky = 3, oddly_breakable_by_hand = 2, stone = 1}, | ||
| sounds = default.node_sound_stone_defaults(), | ||
| groups = get_dig_groups(recipeitem), |
Member
There was a problem hiding this comment.
What about the stone group? I believe that one should be preserved.
Member
Author
There was a problem hiding this comment.
stone is not a dig group, but rather a group identifying that it is stone.
Member
There was a problem hiding this comment.
I know. Is there a particular reason why that group is no longer used? It can still be relevant for recipes.
SmallJoker
reviewed
Jun 14, 2026
This PR fixes the digging groups and sound by having them follow their recipe node. To make sure the data is readable during registration, all material mods are added as optional dependencies.
Emojigit
force-pushed
the
fork-20240615-group-sound-fix
branch
from
June 15, 2026 11:29
399f6ab to
b32e979
Compare
Sheriff-Unit-3
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the digging groups and sound by having them follow their recipe node. To make sure the data is readable during registration, all material mods are added as optional dependencies.
This PR is ready for review.