Repository navigation
fix(f117): restore unified delivery with Redis and readiness recovery - #224
Merged
Merged
Conversation
…very Why: restore the reviewed common send and drain after the #222/#223 rollback, correcting Redis empty target encoding and preserving guidance until the exact native parent dispatcher is ready. Add composed Redis and HTTP Steer regression coverage. Source: fd09784d3f4aea51b365258251639badbab90a9e Source-tree: 6babe29 Fork-base: c29dba7 Fork-only #221 plugin changes and pre-existing evidence retained. Runtime acceptance and soak remain pending; no process or storage changes.
mindfn
force-pushed
the
fix/f117-preparing-guidance
branch
from
October 10, 2026 15:44
0c9455a to
247a8cf
Compare
mindfn
marked this pull request as ready for review
October 11, 2026 13:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the unified message send and queue drain after the #222/#223 rollback, with both normal-send regressions corrected. The comparison is against the accepted #221 tree restored in
c29dba70; it includes the reviewed unified-delivery changes, rather than only the preparation fix.Published head:
247a8cf93893453968ee22bbc9f34c6c2b95c090. Its file tree normalizes exactly to reviewed sourcefd09784d3f4aea51b365258251639badbab90a9e, retaining the fork-only #221 plugin changes and baseline files. No process evidence packages are added.Validation: author focused API regressions 247/247 and native-owner contract fixtures 50/50 passed. Astra independently ran the composed Redis/Steer and conversion checks, 7/7 passed; earlier exact preparation review remains recorded separately. Native dispatch is controlled by test fixtures, not a live provider. The repository CI workflow only targets PRs into main; this develop_base PR has no automatic checks. Remote CI is being collected on the same source tree in upstream draft zts212653#1398, head
fdce1bc25ee18ebbc9511e46c43517345652626e, and has completed with 16 successful checks plus one planned serial-bootstrap skip (CI run38064976487; Windows run38064976484).Keep Draft pending exact-candidate acceptance and operator experience/soak. The running checkout remains the accepted #221 rollback; it has not been updated or restarted. The delayed native session eventually connected, but the prior writer release cause is not established. This is not a declaration that the runtime incident is fully resolved.
Additional isolated provider check: real Redis/send/drain plus the production CodexAppServerClient and installed CLI passed 2/2 (automatic guidance and real HTTP Steer). Both fresh native sessions consumed the appended instruction and completed one turn; no transport stub was used. The routing/lifecycle adapter remains controlled, so this is not full index/browser or operator/soak acceptance. Existing runtime sessions and data were untouched.
Exact-candidate acceptance update (2026-10-10): Astra independently passed the complete product index → HTTP → isolated Redis → real Codex path, 2/2. Console interactions on exact fork HEAD 247a8cf then passed automatic guidance and visible Queue Steer, 2/2: each retained one native turn and one response carrying both inputs, guidance read receipts, and final empty Queue/active execution. Reload preserved the receipts. These are separate runs, not a combined test count. One Steer follow-up returned ENTRY_NOT_FOUND after ordinary drain won delivery; the existing client convergence handled it with no failure toast or duplicate execution. This is not a claim of zero network errors. Only one configured Codex member was exercised. Isolated services are stopped, all data retained, runtime stays on the #221 rollback. Keep Draft until operator experience and fork soak; earlier native writer release remains unexplained.