MOBILE-451:Resolve a place as if its last operation were still in effect for the session - #773
Merged
Merged
Conversation
added 3 commits
September 21, 2026 18:26
sergeysozinov
force-pushed
the
feature/MOBILE-451
branch
from
September 21, 2026 15:27
12aa7a1 to
e2237d8
Compare
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The broad concurrency-sensitive session-state migration warrants final human validation despite no specific defect being identified.
Review effort: Balanced
Findings: None
What changed in this PR
Adds session-scoped operation memory so embedded places can reuse their latest operation during subsequent resolution.
Changes:
- Introduces replaceable
SessionStatestorage. - Remembers the latest operation per embedded place.
- Updates affected components and tests to use session state.
| File | Description |
|---|---|
sdk/src/main/.../SessionState.kt |
Defines consolidated session state. |
sdk/src/main/.../SessionStorageManager.kt |
Resets sessions by replacing state. |
sdk/src/main/.../InAppInteractorImpl.kt |
Reuses remembered place operations. |
sdk/src/main/.../interfaces/interactors/InAppInteractor.kt |
Documents operation reuse behavior. |
sdk/src/main/.../MobileConfigSettingsManagerImpl.kt |
Migrates session timing state. |
sdk/src/main/.../InappSettingsManagerImpl.kt |
Migrates in-app limits state. |
sdk/src/main/.../WebViewInappViewHolder.kt |
Reads trigger events from state. |
sdk/src/main/.../InAppMessageManagerImpl.kt |
Stores config errors in state. |
sdk/src/main/.../ViewProductSegmentNode.kt |
Migrates segmentation status. |
sdk/src/main/.../MobileConfigRepositoryImpl.kt |
Reads config errors from state. |
sdk/src/main/.../InAppTargetingErrorRepositoryImpl.kt |
Migrates targeting errors. |
sdk/src/main/.../InAppSegmentationRepositoryImpl.kt |
Migrates segmentation data. |
sdk/src/main/.../InAppRepositoryImpl.kt |
Migrates in-app session data. |
sdk/src/main/.../InAppGeoRepositoryImpl.kt |
Migrates geo status. |
sdk/src/main/.../ShowBudgetManagerImpl.kt |
Migrates show reservations. |
sdk/src/main/.../InAppFailureTrackerImpl.kt |
Migrates failure tracking. |
sdk/src/main/.../MinIntervalBetweenShowsLimitChecker.kt |
Reads limits from state. |
sdk/src/main/.../MaxInappsPerSessionLimitChecker.kt |
Reads session limits from state. |
sdk/src/main/.../MaxInappsPerDayLimitChecker.kt |
Reads daily limits from state. |
sdk/src/test/.../MobileConfigSettingsManagerTest.kt |
Updates session-time assertions. |
sdk/src/test/.../DataCollectorTest.kt |
Updates trigger-event setup. |
sdk/src/test/.../DataCollectorParamsTest.kt |
Updates trigger-event setup. |
sdk/src/test/.../InAppMessageManagerTest.kt |
Tests state-backed config errors. |
sdk/src/test/.../ViewProductSegmentNodeTest.kt |
Updates segmentation state setup. |
sdk/src/test/.../InAppProcessingManagerTest.kt |
Updates targeting status assertions. |
sdk/src/test/.../EmbeddedResolveInteractorTest.kt |
Covers remembered operations. |
sdk/src/test/.../InAppTargetingErrorRepositoryTest.kt |
Updates targeting-error fixtures. |
sdk/src/test/.../InAppSegmentationRepositoryTest.kt |
Updates segmentation fixtures. |
sdk/src/test/.../InAppRepositoryTest.kt |
Updates repository state fixtures. |
sdk/src/test/.../InAppGeoRepositoryTest.kt |
Updates geo state fixtures. |
sdk/src/test/.../ShowBudgetManagerImplTest.kt |
Updates reservation state assertions. |
sdk/src/test/.../SessionStorageManagerTest.kt |
Covers complete state replacement. |
sdk/src/test/.../MinIntervalBetweenShowsLimitCheckerTest.kt |
Updates limit fixtures. |
sdk/src/test/.../MaxInappsPerSessionLimitCheckerTest.kt |
Updates session-limit fixtures. |
sdk/src/test/.../MaxInappsPerDayLimitCheckerTest.kt |
Updates daily-limit fixtures. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
enotniy
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILE-451