Skip to content

MOBILE-453: add logs for maintenance - #770

Merged
sergeysozinov merged 4 commits into
mission/storiesfrom
feature/MOBILE-453
Sep 18, 2026
Merged

sergeysozinov merged 4 commits into
mission/storiesfrom
feature/MOBILE-453

Conversation

@sergeysozinov

Copy link
Copy Markdown
Collaborator

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Generic parsing errors still omit the newly available in-app ID, limiting their diagnostic value.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds maintenance diagnostics for WebView requests, in-app deserialization, and A/B-test filtering.

Changes:

  • Logs WebView response metadata and selected cache headers.
  • Identifies unknown config subtypes as warnings tied to in-app IDs.
  • Logs in-apps removed by A/B-test filtering and adds coverage.
File summaries
File Description
sdk/src/main/java/cloud/mindbox/mobile_sdk/network/WebViewContentRequest.kt Adds WebView response logging.
sdk/src/main/java/cloud/mindbox/mobile_sdk/managers/GatewayManager.kt Uses the logging request implementation.
sdk/src/main/java/cloud/mindbox/mobile_sdk/utils/RuntimeTypeAdapterFactory.java Introduces a distinct unknown-subtype exception.
sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/data/managers/MobileConfigSerializationManagerImpl.kt Classifies and contextualizes parsing failures.
sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/domain/interfaces/managers/MobileConfigSerializationManager.kt Adds in-app IDs to deserialization APIs.
sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/data/repositories/MobileConfigRepositoryImpl.kt Supplies IDs during deserialization.
sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/presentation/InAppWebViewPrewarmManager.kt Supplies IDs during prewarm parsing.
sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/domain/InAppInteractorImpl.kt Logs A/B-test exclusions.
sdk/src/test/java/cloud/mindbox/mobile_sdk/network/WebViewContentRequestTest.kt Tests response logging and caching.
sdk/src/test/java/cloud/mindbox/mobile_sdk/inapp/domain/InAppInteractorImplTest.kt Tests config-level exclusion logs.
sdk/src/test/java/cloud/mindbox/mobile_sdk/inapp/domain/EmbeddedResolveInteractorTest.kt Tests place-level exclusion logs.
sdk/src/test/java/cloud/mindbox/mobile_sdk/inapp/data/repositories/MobileConfigRepositoryImplTest.kt Updates serializer mocks.
sdk/src/test/java/cloud/mindbox/mobile_sdk/inapp/data/managers/serialization/MobileConfigSerializationManagerTest.kt Updates serializer calls with IDs.
sdk/src/test/java/cloud/mindbox/mobile_sdk/inapp/data/managers/serialization/EmbeddedContractSerializationTest.kt Tests subtype warning behavior.
Review details
  • Files reviewed: 14/14 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sergeysozinov
sergeysozinov merged commit 991d762 into mission/stories Sep 18, 2026
6 checks passed
@sergeysozinov
sergeysozinov deleted the feature/MOBILE-453 branch September 18, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants