MOBILE-453: add logs for maintenance - #770
Merged
Merged
Conversation
added 3 commits
September 17, 2026 16:54
…ror with a stack trace
…ze at debug level
There was a problem hiding this comment.
🟡 Changes recommended
Generic parsing errors still omit the newly available in-app ID, limiting their diagnostic value.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds maintenance diagnostics for WebView requests, in-app deserialization, and A/B-test filtering.
Changes:
- Logs WebView response metadata and selected cache headers.
- Identifies unknown config subtypes as warnings tied to in-app IDs.
- Logs in-apps removed by A/B-test filtering and adds coverage.
File summaries
| File | Description |
|---|---|
sdk/src/main/java/cloud/mindbox/mobile_sdk/network/WebViewContentRequest.kt |
Adds WebView response logging. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/managers/GatewayManager.kt |
Uses the logging request implementation. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/utils/RuntimeTypeAdapterFactory.java |
Introduces a distinct unknown-subtype exception. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/data/managers/MobileConfigSerializationManagerImpl.kt |
Classifies and contextualizes parsing failures. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/domain/interfaces/managers/MobileConfigSerializationManager.kt |
Adds in-app IDs to deserialization APIs. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/data/repositories/MobileConfigRepositoryImpl.kt |
Supplies IDs during deserialization. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/presentation/InAppWebViewPrewarmManager.kt |
Supplies IDs during prewarm parsing. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/domain/InAppInteractorImpl.kt |
Logs A/B-test exclusions. |
sdk/src/test/java/cloud/mindbox/mobile_sdk/network/WebViewContentRequestTest.kt |
Tests response logging and caching. |
sdk/src/test/java/cloud/mindbox/mobile_sdk/inapp/domain/InAppInteractorImplTest.kt |
Tests config-level exclusion logs. |
sdk/src/test/java/cloud/mindbox/mobile_sdk/inapp/domain/EmbeddedResolveInteractorTest.kt |
Tests place-level exclusion logs. |
sdk/src/test/java/cloud/mindbox/mobile_sdk/inapp/data/repositories/MobileConfigRepositoryImplTest.kt |
Updates serializer mocks. |
sdk/src/test/java/cloud/mindbox/mobile_sdk/inapp/data/managers/serialization/MobileConfigSerializationManagerTest.kt |
Updates serializer calls with IDs. |
sdk/src/test/java/cloud/mindbox/mobile_sdk/inapp/data/managers/serialization/EmbeddedContractSerializationTest.kt |
Tests subtype warning behavior. |
Review details
- Files reviewed: 14/14 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
enotniy
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILE-453