MOBILE-506: Fix memory leak - #769
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, targeted, and reduces the risk of retaining an Activity reference without altering functional behavior.
Pull request overview
This PR addresses a potential memory leak in the SDK lifecycle callbacks by avoiding capturing an Activity instance inside a coroutine launched from onActivityStarted.
Changes:
- Extract
activity.applicationContextinto a localappContextand pass that intoupdateAppInfo(...)from the coroutine to prevent retaining theActivity.
File summaries
| File | Description |
|---|---|
| sdk/src/main/java/cloud/mindbox/mobile_sdk/Mindbox.kt | Avoids capturing Activity in a coroutine by using applicationContext when updating app info. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sergeysozinov
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILE-506