Deleted yarn.lock, we're using npm instead. - #1
Open
eostrom wants to merge 9 commits into
Open
Conversation
added 8 commits
October 22, 2019 12:19
Author
|
Please disregard, I'll target rosslh/master instead. |
The presence of `yarn.lock` can lead developers to install with `yarn`, and then we have two lock files that get out of sync. Better to just keep one package manager.
eostrom
force-pushed
the
fix-prettier-setup
branch
from
October 22, 2019 16:59
22923e6 to
ae55e1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The presence of
yarn.lockcan lead developers to install withyarn, and then we have two lock files that get out of sync.Better to just keep one package manager.
(I'm submitting this as a PR to your
fix-prettier-setupbranch because it feels to me like part of the same cleanup project, but if you disagree I'll just submit it to the master.)