[mikolaj92]

Issue #123

Wydzielone z #113.

Cel: usunąć FalaArtifactStore (symbol w module datasource_kit.adapters.fala) wraz z eksportem i użyciem modułu fala.artifacts oraz plik tests/adapters/test_fala_artifact_store.py. Zachowaj ogólny protokół ArtifactStore i FalaExecutionBackend. Nie dodawaj komentarzy, docstringów ani testów jednostkowych.

Kroki dotyczące testów:

1. Przenieś bez zmian test test_importing_core_and_adapters_when_fala_missing (razem z funkcją pomocniczą _block_fala_imports i potrzebnymi importami) z tests/adapters/test_fala_artifact_store.py do nowego pliku tests/adapters/test_adapters_import.py. Treść obu funkcji, łącznie z komentarzami, ma zostać identyczna; ten test sprawdza kod, który zostaje (import datasource_kit i datasource_kit.adapters bez fala).
2. Usuń w całości tests/adapters/test_fala_artifact_store.py razem z kodem, który testuje: symbolem FalaArtifactStore z modułu datasource_kit.adapters.fala oraz użyciem modułu fala.artifacts.

Kryterium odbioru: kod nie importuje fala.artifacts, nie udostępnia FalaArtifactStore, a import datasource_kit i datasource_kit.adapters bez fala nadal przechodzi przeniesiony test.

Zmienione pliki

pyproject.toml                             |  1 -
 src/datasource_kit/adapters/fala.py        | 61 +---------------------
 tests/adapters/test_fala_artifact_store.py | 83 ++++--------------------------
 3 files changed, 12 insertions(+), 133 deletions(-)

Checks

SHA: 7c8f2de455b3d3bc3f234eeb2f20c7cfd49d569f

name	status	reason
ci_green	pass	GitHub CI green at 7c8f2de; expected green or no_ci at 7c8f2de
local_tests	pass	319 passed
merge_clean	pass	merge is clean
lockfile	pass	uv lock checks passed
secrets	pass	no secrets found
junk	pass	no generated junk files
no_new_comments	pass	no new comments or lint errors
no_unit_tests	pass	no new unit tests
weakened_tests	pass	no test assertions removed
deleted_files	pass	no deleted files
encoded_rewrite	pass	no percent-encoded rewrites
intent	pass	no code intent mismatch
docs	pass	no documentation expansion

Uwagi bez konkretu

• alignment: tests/adapters/test_fala_artifact_store.py:3-66:
• architecture: tests/adapters/test_fala_artifact_store.py:3-66:
• correctness: tests/adapters/test_fala_artifact_store.py:3-66:
• production: tests/adapters/test_fala_artifact_store.py:3-66:
• scope: tests/adapters/test_fala_artifact_store.py:3-66:
• tests: tests/adapters/test_fala_artifact_store.py:3-66:

Closes #123

Opened by lokay.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-23T14:25:27.862358Z We couldn’t complete this review. Comment @codex review to try again.	7c8f2de	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[mikolaj92]

Lokay Check 1

SHA: 7c8f2de455b3d3bc3f234eeb2f20c7cfd49d569f

Wynik: pending · CI: pending · tests: pending · tested=false

Uwagi i CI:

{
  "uwagi": [],
  "notes": [],
  "failed": [],
  "pending": [
    "test (3.12)",
    "test (3.13)"
  ]
}

[mikolaj92]

Lokay Check 1

SHA: 7c8f2de455b3d3bc3f234eeb2f20c7cfd49d569f

Wynik: merge · CI: green · tests: green · tested=true

name	status	reason
ci_green	pass	GitHub CI green at 7c8f2de; expected green or no_ci at 7c8f2de
local_tests	pass	319 passed
merge_clean	pass	merge is clean
lockfile	pass	uv lock checks passed
secrets	pass	no secrets found
junk	pass	no generated junk files
no_new_comments	pass	no new comments or lint errors
no_unit_tests	pass	no new unit tests
weakened_tests	pass	no test assertions removed
deleted_files	pass	no deleted files
encoded_rewrite	pass	no percent-encoded rewrites
intent	pass	no code intent mismatch
docs	pass	no documentation expansion

Uwagi i CI:

{
  "uwagi": [],
  "notes": [],
  "failed": [],
  "pending": []
}