fix: support Ruby 4 by allowing Rouge 4.x#95
Merged
Conversation
chadlwilson
force-pushed
the
support-ruby-4
branch
from
4c6e874 to
96bc255
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 4.x dropped
CGIalmost entirely, which Rouge 3.x depends on, thus supporting Ruby 4.x requires allowing Rouge 4.x, which has been out for 3 years; supports Ruby 2.7+ and appears very stable.The breaking changes in Rouge 4.x don't affect modern middleman since they mainly are just dropping Ruby < 2.7:
https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md#version-400-2022-09-04
Also dropped the dev-only Gemfile haml restriction, as the monkey patch seems to work fine with haml 7; and haml 6 and tests seems to work perfectly fine on Ruby 2.7. Since we dropped Ruby < 2.7 some time ago, perhaps this restriction was intended for even older Rubies.