fix(api): Isolate API package validation consumers from ambient type definitions - #1800
Open
Satyam Pandey (SatyamPandey-07) wants to merge 2 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
Author
|
Bill Schnurr (@bschnurr) Hi, just bumping this PR in case it slipped through your notifications. Let me know if you need any changes or further testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #1799
Changes Proposed
"types": ["node", "vscode"]and"typeRoots": ["../node_modules/@types"]inapi/test/tsconfig.modern.jsonandapi/test/tsconfig.legacy.jsonto preventtscfrom traversing parent directories for ambient type definitions.api/scripts/test-package.cjsto resolvetypescript/bin/tscdynamically viacreateRequireinstead of hardcodingpackageRoot/node_modules/typescript/bin/tsc."test": "npm run test:package"toapi/package.jsonso standardnpm testruns package validation.How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
npm --prefix api run test:packagecompleted with 0 errors (modern and legacy consumers verified).npm --prefix api testran successfully.npm run unittest) passed with 2,411 passing tests.npm run lint) passed with 0 errors/warnings.npm run compile-tests) succeeded with 0 errors.Checklist