Commit 381a8b1
Don't prompt to fetch additional remotes when user explicitly configures them (#8219)
* Initial plan
* Initial analysis of remote fetching issue
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
* Fix: Don't prompt to fetch additional remotes when explicitly configured
When users explicitly configure githubPullRequests.remotes, the extension
should automatically fetch from all configured remotes instead of prompting
"Continue fetching from other remotes" after finding results in the first one.
This change modifies the fetchPagedData method to detect when remotes have
been explicitly configured (via global, workspace, or folder settings) and
skips the early break logic that was causing the prompt to appear.
Fixes microsoft/vscode-pull-request-github#XXXXX
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
* Address code review feedback: improve variable names and readability
- Renamed hasExplicitRemotesConfig to hasUserConfiguredRemotes for clarity
- Extracted complex conditional logic into well-named boolean variables
(hasReceivedData, isFetchingNextPage, hasReachedPreviousFetchLimit, shouldBreakEarly)
to improve readability and make the logic more self-documenting
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
* Revert unrelated change to vscode.proposed.chatParticipantAdditions.d.ts
* Fix: Preserve hasMorePages to show "Load more" button
When user configures remotes and we loop through all of them, we should
preserve itemData.hasMorePages so that the "Load more" button appears
if any repository has more pages. Previously, we were returning
hasMorePages: false which prevented the "Load more" button from showing.
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
* Remove unrelated change to vscode.proposed.chatParticipantAdditions.d.ts
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>1 parent adba5c4 commit 381a8b1
1 file changed
Lines changed: 13 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1086 | 1086 | | |
1087 | 1087 | | |
1088 | 1088 | | |
| 1089 | + | |
| 1090 | + | |
| 1091 | + | |
| 1092 | + | |
1089 | 1093 | | |
1090 | 1094 | | |
1091 | 1095 | | |
| |||
1148 | 1152 | | |
1149 | 1153 | | |
1150 | 1154 | | |
1151 | | - | |
| 1155 | + | |
1152 | 1156 | | |
1153 | 1157 | | |
1154 | 1158 | | |
1155 | | - | |
1156 | | - | |
1157 | | - | |
1158 | | - | |
1159 | | - | |
| 1159 | + | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
1160 | 1166 | | |
1161 | 1167 | | |
1162 | 1168 | | |
| |||
1173 | 1179 | | |
1174 | 1180 | | |
1175 | 1181 | | |
1176 | | - | |
| 1182 | + | |
1177 | 1183 | | |
1178 | 1184 | | |
1179 | 1185 | | |
| |||
0 commit comments