Suppress RemoveReaction permission errors during rapid reaction toggling (#8225)

* Initial plan

* Initial plan for handling reaction permission errors

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Fix: Ignore GraphQL permission error when quickly toggling reactions

When users quickly click on a reaction to add/remove it, a race condition
can occur where the client tries to remove a reaction that the user doesn't
have permission to remove. This results in a GraphQL error:
"does not have the correct permissions to execute 'RemoveReaction'"

This change silently ignores this specific error as it's expected behavior
during rapid toggling of reactions.

Fixes microsoft/vscode#69321

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Refactor: Use consistent error handling in both toggleReaction implementations

- Import formatError in pullRequestCommentController.ts
- Use formatError(e) consistently in both implementations
- Throw new Error(errorMessage) consistently instead of rethrowing original error

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Fix message

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

Author: Copilot

src/view/pullRequestCommentController.ts

@@ -12,7 +12,7 @@ import { disposeAll } from '../common/lifecycle';
 import Logger from '../common/logger';
 import { ITelemetry } from '../common/telemetry';
 import { fromPRUri, Schemes } from '../common/uri';
-import { groupBy } from '../common/utils';
+import { formatError, groupBy } from '../common/utils';
 import { PULL_REQUEST_OVERVIEW_VIEW_TYPE } from '../common/webview';
 import { FolderRepositoryManager } from '../github/folderRepositoryManager';
 import { GitHubRepository } from '../github/githubRepository';
@@ -546,14 +546,25 @@ export class PullRequestCommentController extends CommentControllerBase implemen
 			return;
 		}
 
-		if (
-			comment.reactions &&
-			!comment.reactions.find(ret => ret.label === reaction.label && !!ret.authorHasReacted)
-		) {
-			// add reaction
-			await this.pullRequestModel.addCommentReaction(comment.rawComment.graphNodeId, reaction);
-		} else {
-			await this.pullRequestModel.deleteCommentReaction(comment.rawComment.graphNodeId, reaction);
+		try {
+			if (
+				comment.reactions &&
+				!comment.reactions.find(ret => ret.label === reaction.label && !!ret.authorHasReacted)
+			) {
+				// add reaction
+				await this.pullRequestModel.addCommentReaction(comment.rawComment.graphNodeId, reaction);
+			} else {
+				await this.pullRequestModel.deleteCommentReaction(comment.rawComment.graphNodeId, reaction);
+			}
+		} catch (e) {
+			// Ignore permission errors when removing reactions due to race conditions
+			// See: https://github.com/microsoft/vscode/issues/69321
+			const errorMessage = formatError(e);
+			if (errorMessage.includes('does not have the correct permissions to execute `RemoveReaction`')) {
+				// Silently ignore this error - it occurs when quickly toggling reactions
+				return;
+			}
+			throw new Error(errorMessage);
 		}
 	}
 

src/view/reviewCommentController.ts

@@ -985,7 +985,14 @@ ${suggestionInformation.suggestionContent}
 				);
 			}
 		} catch (e) {
-			throw new Error(formatError(e));
+			// Ignore permission errors when removing reactions due to race conditions
+			// See: https://github.com/microsoft/vscode/issues/69321
+			const errorMessage = formatError(e);
+			if (errorMessage.includes('does not have the correct permissions to execute `RemoveReaction`')) {
+				// Silently ignore this error - it occurs when quickly toggling reactions
+				return;
+			}
+			throw new Error(errorMessage);
 		}
 	}