Remove duplicate file-naming utilities from CtrfReportEngine in favor of SharedExtensionHelpers

[Copilot]

CtrfReportEngine.FileNaming.cs contained private reimplementations of three utilities already shared across JUnit/HTML/TRX report engines, including an acknowledgment comment that the duplication was a maintenance risk.

Changes

• .csproj: Link ReportFileNameSanitizer.cs, ReportFileNameHelper.cs, and TargetFrameworkMonikerHelper.cs from SharedExtensionHelpers (mirrors what JUnitReport and HtmlReport already do)

• CtrfReportEngine.FileNaming.cs:

  • GetTargetFrameworkMoniker() → TargetFrameworkMonikerHelper.GetTargetFrameworkMoniker()
  • ResolveJsonFileName() body → ReportFileNameHelper.ResolveAndSanitize() (eliminates manual template-resolve + sanitize reimplementation)
  • ReplaceInvalidFileNameChars() + IsInvalidFileNameChar() + IsReservedFileName() (~50 lines) → single delegation to ReportFileNameSanitizer.ReplaceInvalidFileNameChars()

• ReportFileNameSanitizationConsistencyTests.cs: Added TrxAndCtrfReportEngines_UseSameFileNameSanitizationRules to cover CTRF in the cross-engine sanitization parity checks

// Before: private reimplementations with a comment admitting alignment risk
private static string GetTargetFrameworkMoniker()
    => TargetFrameworkParser.GetShortTargetFrameworkIncludingPlatform(Assembly.GetEntryAssembly()) ?? "unknown";
// "Keep the explicit file-name sanitization aligned with TRX report naming"
private static bool IsInvalidFileNameChar(char c) => ...
private static bool IsReservedFileName(string fileName) { /* 15 lines */ }

// After: delegate to shared helpers
private string ResolveJsonFileName(string template)
    => ReportFileNameHelper.ResolveAndSanitize(template, processName, processId, _clock.UtcNow);

private static string ReplaceInvalidFileNameChars(string fileName)
    => ReportFileNameSanitizer.ReplaceInvalidFileNameChars(fileName);

[Copilot]

Pull request overview

This PR removes duplicated CTRF report file-naming/sanitization logic by delegating to the existing SharedExtensionHelpers utilities already used by the JUnit/HTML/TRX report engines, and extends the cross-engine parity unit tests to include CTRF.

Changes:

• Linked ReportFileNameHelper, ReportFileNameSanitizer, and TargetFrameworkMonikerHelper into the CTRF extension project.
• Updated CtrfReportEngine.FileNaming.cs to delegate TFM resolution, template resolution + sanitization, and filename sanitization to the shared helpers.
• Added a new unit test to ensure CTRF and TRX use identical filename sanitization rules.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/ReportFileNameSanitizationConsistencyTests.cs	Adds CTRF to the existing TRX-vs-other-engine sanitization parity checks via reflection.
src/Platform/Microsoft.Testing.Extensions.CtrfReport/Microsoft.Testing.Extensions.CtrfReport.csproj	Links shared file-naming/sanitization/TFM helper sources from SharedExtensionHelpers.
src/Platform/Microsoft.Testing.Extensions.CtrfReport/CtrfReportEngine.FileNaming.cs	Replaces local implementations with calls to shared helper utilities for consistency and maintenance.

Copilot's findings

• Files reviewed: 3/3 changed files
• Comments generated: 0