bindings/python: bump PyO3 to 0.29.0 to remediate GHSA-36hh-v3qg-5jq4#752
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix out-of-bounds read in PyO3 iterator methods
bindings/python: bump PyO3 to 0.29.0 to remediate GHSA-36hh-v3qg-5jq4
Jun 23, 2026
anakrish
approved these changes
Jun 23, 2026
dpokluda
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyO3 versions before 0.29.0 contain an out-of-bounds read vulnerability in optimized
nth/nth_backimplementations forPyList/PyTupleiterators. This PR applies the minimum patched version in the affected manifest (bindings/python/Cargo.lockcontext) to clear the high-severity advisory with minimal change surface.Dependency remediation
bindings/python/Cargo.tomlfrompyo3 = 0.28.3topyo3 = 0.29.0(lowest patched version).bindings/python/Cargo.lockvia Cargo tooling, updating:pyo30.28.3 -> 0.29.0pyo3-build-config0.28.3 -> 0.29.0pyo3-ffi0.28.3 -> 0.29.0pyo3-macros0.28.3 -> 0.29.0pyo3-macros-backend0.28.3 -> 0.29.0Reachability Assessment
Iterator::nth/DoubleEndedIterator::nth_backon PyO3 list/tuple iterators.bindings/python/src/lib.rs, list/tuple handling uses straightforwardfor v in plist/for v in ptupleiteration; there are no direct calls tonthornth_backin this binding.Original prompt
This section details the Dependabot vulnerability alert you should resolve
<alert_title>PyO3 has an Out-of-bounds Read in
nth/nth_backforPyListandPyTupleiterators</alert_title><alert_description>PyO3 0.24.0 added optimized implementations of
Iterator::nthandDoubleEndedIterator::nth_backfor theBoundListIteratorandBoundTupleIteratortypes. These implementations computed the target index using uncheckedusizeaddition (index + n) before bounds-checking against the sequence length, then read the element viaget_item_unchecked.In
nthmethods, a sufficiently largen(combined with a non-zero internal index) could cause the addition to overflow and wrap around, producing a small "target index" that passed the bounds check and enabling reads at the front of thelistortupleof elements previously yielded by the iterator.In
nth_backmethods, a sufficiently largencould cause underflow in a similar fashion, however would instead allow reads of arbitrary memory past the end of thelistortuplestorage.</alert_description>high
https://github.com/PyO3/pyo3/pull/6086 https://rustsec.org/advisories/RUSTSEC-2026-0176.html https://github.com/advisories/GHSA-36hh-v3qg-5jq4GHSA-36hh-v3qg-5jq4
pyo3
rust
<vulnerable_versions>= 0.28.3</vulnerable_versions>
<patched_version>0.29.0</patched_version>
<manifest_path>bindings/python/Cargo.lock</manifest_path>
<agent_instructions>Look at how other projects have addressed this and implement a similar fix.</agent_instructions>
<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known breaking changes, review the changelog or release notes, then audit the codebase for usage of affected APIs and fix any breaking changes that are found. If the package manager fails to resolve dependencies (e.g. peer dependency conflicts, incompatible engine constraints), document the error in the PR description rather than attempting increasingly complex workarounds. After updating, check the lock file to confirm the package no longer resolves to a version in the vulnerable range. Keep changes minimal and tightly scoped. Ensure tests, build, type checking, and linting all pass after your changes. If there are any test, lint, or typechecking failures, investigate whether they are caused by the update and fix them if so — do not leave broken tests in the PR. If they were already present before the update, note them in the PR descript...