[0.76] Fix unhandled synchronous throw from WebSocket ConnectAsync - #15794
Closed
Julio César Rocha (JunielKatarn) wants to merge 1 commit into
Closed
[0.76] Fix unhandled synchronous throw from WebSocket ConnectAsync#15794Julio César Rocha (JunielKatarn) wants to merge 1 commit into
Julio César Rocha (JunielKatarn) wants to merge 1 commit into
Conversation
…t#15783) * Fix unhandled synchronous throw from ConnectAsync (Generated summary) ConnectAsync can throw synchronously (e.g. WININET_E_INVALID_CA / 0x80072EE1 on certificate validation failure) before returning an IAsyncAction. Move the call inside the existing try/catch block so such exceptions are routed through Fail() instead of propagating unhandled. Add ConnectAsyncThrowsSynchronously unit test to cover this path. * Change files * Add explaining comment * clang format
Khalef Hosany (Khalef1)
approved these changes
Mar 17, 2026
Julio César Rocha (JunielKatarn)
enabled auto-merge (squash)
March 17, 2026 01:03
Member
|
Julio César Rocha (@JunielKatarn) , I am closing this PR since we do not support 0.76 branch anymore. The PR, CI, and Release pipelines do not work for this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #15783
Microsoft Reviewers: Open in CodeFlow