Repository navigation
fix(macos): run useNativeDriver animations on the new architecture - #3145
Open
Bron Davies (brondavies) wants to merge 1 commit into
Open
Bron Davies (brondavies) wants to merge 1 commit into
Bron Davies (brondavies) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #3079.
shouldUseTurboAnimatedModule()picksNativeAnimatedTurboModuleonly whenPlatform.OS === 'ios'. On macOS under the new architecture, Animated falls back toNativeAnimatedModule, whose operation queue only the bridge flushes, so nouseNativeDriver: trueanimation starts and its callback never fires.Test Plan:
RNTester-macOS (Debug, arm64, Xcode 27.1, macOS 26.6.2), Playground running
Animated.timing(opacity, {toValue: 1, duration: 300, useNativeDriver: true})on anAnimated.View:main, the view stays invisible and thestartcallback never fires.finished: true.