Skip to content

fix(macos): draw a TextInput's plain text and bullets in its color #3144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bron Davies (brondavies) wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

fix(macos): draw a TextInput's plain text and bullets in its color #3144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/react-native/Libraries/Text/TextInput/Singleline/RCTUITextField.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,13 @@ - (void)setDefaultTextAttributes:(NSDictionary<NSAttributedStringKey, id> *)defa
attributes:[self defaultTextAttributes]]];

self.font = [[self defaultTextAttributes] objectForKey:NSFontAttributeName];

// Plain text set later (`text`) and a secure field's bullets are drawn in textColor, not in the
// attributed text's color, so it has to follow the style too.
NSColor *textColor = [[self defaultTextAttributes] objectForKey:NSForegroundColorAttributeName];
if (textColor != nil) {
self.textColor = textColor;
}
#endif // macOS]
}

Expand Down