Skip to content

fix(macos): keep a press on a view from reaching a text field beneath it #3143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bron Davies (brondavies) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(macos): keep a press on a view from reaching a text field beneath it #3143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2323,6 +2323,14 @@ - (void)mouseExited:(NSEvent *)event
[self emitMouseEvent:MouseLeave];
}

- (void)mouseDown:(NSEvent *)event
{
// Accept mouseDown: the surface's touch handler, a gesture recognizer, has already taken the
// press. NSView's default passes it on to an overlapping sibling view beneath the point, and a
// text field there starts a tracking loop that consumes the mouseUp, so a button drawn over a
// TextInput would never be pressed.
}

- (void)mouseUp:(NSEvent *)event
{
BOOL hasDoubleClickEventHandler = _props->hostPlatformEvents[HostPlatformViewEvents::Offset::DoubleClick];
Expand Down