Skip to content

fix(macos): stop a secure TextInput throwing as it takes focus #3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bron Davies (brondavies) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(macos): stop a secure TextInput throwing as it takes focus #3141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/react-native/Libraries/Text/TextInput/Singleline/macOS/RCTUISecureTextField.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,24 @@ + (Class)cellClass
return RCTUISecureTextFieldCell.class;
}

// AppKit's secure field editor (NSSecureTextView) requires its delegate to be an NSSecureTextField,
// and throws as the field takes focus when it is not ("NSSecureTextFieldCell is not secure because
// the secure field editor's delegate must be an NSSecureTextField!"). This class subclasses
// RCTUITextField to share its behaviour, but its cell is an NSSecureTextFieldCell, which masks the
// text and turns on secure keyboard input, so it answers as an NSSecureTextField.
- (BOOL)isKindOfClass:(Class)aClass
{
return aClass == [NSSecureTextField class] || [super isKindOfClass:aClass];
}

// Taken for an NSSecureTextField, the field is also asked this by NSSecureTextView as it draws, and
// an unanswered message throws there. NSSecureTextField answers from a flag that is off unless its
// private setter turns it on, so this answers NO, as an NSSecureTextField does by default.
- (BOOL)_shouldShowIndicators
{
return NO;
}

@end

#endif // TARGET_OS_OSX