chore(ci): modernize workflow actions and use client-id#2044
Merged
Conversation
Silences the Node.js 20 deprecation warning by upgrading actions/checkout and actions/setup-node to v5 (Node.js 24).
Replaces the deprecated app-id input with client-id, sourced from the PLAYWRIGHT_CLIENT_ID repo variable.
The determine-version step still used github-script@v7 (Node.js 20).
yury-s
changed the title
dgozman
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkoutandactions/setup-nodeto@v5(Node.js 24) across all workflows, clearing the Node.js 20 deprecation warning ahead of the June 16 / Sept 16 2026 runner deadlines.determine-versionstep in roll-stable toactions/github-script@v8(it was still on@v7/Node 20).app-idinput ofactions/create-github-app-tokenwithclient-id, sourced from the newPLAYWRIGHT_CLIENT_IDrepo variable, in both roll workflows.Clears the deprecation annotations from https://github.com/microsoft/playwright.dev/actions/runs/26882695531
Note: the old
PLAYWRIGHT_APP_IDrepo variable is no longer referenced and can be removed after merge.