fix: keep multi-browser parametrization when the page fixture is overridden#314
Open
cycsmail wants to merge 1 commit into
Open
fix: keep multi-browser parametrization when the page fixture is overridden#314cycsmail wants to merge 1 commit into
cycsmail wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pagefixture (e.g.def page(page): yield page), some pytest versions dropbrowser_namefrom the fixture closure, so--browser chromium --browser firefoxsilently runs the test against only one browser instead of parametrizing it.pytest_generate_tests, ifbrowser_nameis absent but a browser-backed fixture (page,context,new_context,browser,browser_type) is requested, re-addbrowser_nametometafunc.fixturenamesbefore parametrizing. It's a no-op whenbrowser_nameis already present (pytest 9) or when no browser fixture is used, so non-browser tests are untouched.test_a[chromium]andtest_a[firefox]from an overriddenpagefixture.Reverting the plugin change makes the new tests fail on pytest 8.3.5 (only
test_ais collected), confirming they guard the regression. On pytest 9 the closure already keepsbrowser_name, so the tests pass there regardless.Fixes #172