Skip to content

Keep Python opaque data alive for the lifetime of the request #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gopalakrishnan Nallasamy (GopalakrishnanN) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Keep Python opaque data alive for the lifetime of the request #2445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/python/python.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,9 +748,14 @@ PYBIND11_MODULE(onnxruntime_genai, m) {
.def("has_unseen_tokens", &OgaRequest::HasUnseenTokens)
.def("is_turn_complete", &OgaRequest::IsTurnComplete, "Return whether the current generation turn is complete.")
.def("get_unseen_token", &OgaRequest::GetUnseenToken)
.def("set_opaque_data", [](OgaRequest& request, pybind11::object opaque_data) {
request.SetOpaqueData(opaque_data.ptr());
})
.def(
"set_opaque_data", [](OgaRequest& request, pybind11::object opaque_data) {
request.SetOpaqueData(opaque_data.ptr());
},
// The core stores the PyObject* unowned, so tie its lifetime to the request that
// holds it; otherwise passing a temporary frees it and get_opaque_data() returns
// a dangling pointer.
pybind11::keep_alive<1, 2>())
.def("get_opaque_data", [](OgaRequest& request) -> pybind11::object {
auto opaque_data = request.GetOpaqueData();
if (!opaque_data)
Expand Down
Loading