Remove legacy WebRole debug proxy component#2549
Open
lucygramley wants to merge 1 commit into
Open
Conversation
Delete the entire WebRole directory and all references to it. The WebRole component implements a WebSocket-to-V8-debug-port proxy that has multiple security issues (NTVS-003/004/005): - No authentication beyond a source-controlled GUID (CWE-306) - HtmlDecode/HtmlEncode inversion enabling stored XSS (CWE-79) - Unbounded static log buffer enabling memory exhaustion DoS (CWE-400) The legacy V8 --debug protocol (port 5858) was removed in Node.js 8 (2017), making this component non-functional with any modern Node.js. Changes: - Delete Nodejs/Product/WebRole/ directory - Remove WebRole project from NodejsTools.sln - Remove ProjectReference from Nodejs.csproj and TargetsVsix.csproj - Remove PostBuildEvent that copied WebRole DLL - Remove NtvsDebugProxy handler and rewrite rules from all Web.Debug.config templates (product + test) - Remove legacy node --debug flag from iisnode config transforms Fixes ADO#2982592 (NTVS-003), also resolves ADO#2982593 (NTVS-004) and ADO#2982594 (NTVS-005) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lucygramley
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the entire WebRole debug proxy component:
Why delete instead of fix?
The WebRole component implements a WebSocket-to-V8-debug-port proxy targeting
ode --debug\ (port 5858). This protocol was removed in Node.js 8 (2017) — the component is non-functional with any modern Node.js version. Deleting it eliminates ~570 lines of unmaintained attack surface rather than patching dead code.
What's removed
ode --debug\ flag from iisnode config transforms
Verification