CoreShutdownTests: cover a focused TextBox alive at core shutdown - #11680
Open
Abhijeet Jha (iamAbhi-916) wants to merge 2 commits into
Open
CoreShutdownTests: cover a focused TextBox alive at core shutdown#11680Abhijeet Jha (iamAbhi-916) wants to merge 2 commits into
Abhijeet Jha (iamAbhi-916) wants to merge 2 commits into
Conversation
…utdown Covers the access violation in CInputServices::GetPrimaryRegisteredIslandInputSite when a focused TextBox is still alive as CCoreServices::~CCoreServices deletes the text core. Fixed in main by 691c6a7. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
added
the
needs-triage
Abhijeet Jha (iamAbhi-916)
marked this pull request as ready for review
August 28, 2026 05:42
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
Godly T.Alias (godlytalias)
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds a regression test for the shutdown access violation in CInputServices::GetPrimaryRegisteredIslandInputSite reported in #11653 / #11654, which is already fixed at the root cause in main by 691c6a7 but is still live on the 1.7, 1.8 and 2.x release branches because the fix has not been serviced there yet.
CoreShutdownTests::FocusedTextBoxAtCoreShutdown leaves a focused TextBox in the tree across shutdown so the text core drops the final reference during CCoreServices::~CCoreServices, and faults with 0xC0000005 if m_inputServices is reset before the text core teardown.