[WinUI OSS] Fix GitHub static test package restore - #11657
[WinUI OSS] Fix GitHub static test package restore#11657Sakshi Sharma (sakshisharma150905) wants to merge 5 commits into
Conversation
Pin Windows App SDK 2.4.0 and restore the private WinMD verifier only for non-fork validations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Sakshi Sharma (@sakshisharma150905) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
| inputs: | ||
| command: 'custom' | ||
| arguments: 'install Microsoft.WindowsAppSDK -OutputDirectory $(packagesDir) -ConfigFile $(Build.SourcesDirectory)\nuget.config' | ||
| arguments: 'install Microsoft.WindowsAppSDK -Version 2.4.0 -DependencyVersion Lowest -OutputDirectory $(packagesDir) -ConfigFile $(Build.SourcesDirectory)\nuget.config -NonInteractive' |
There was a problem hiding this comment.
version should not be hardcoded. It can be taken as input. (Default should be latest)
There was a problem hiding this comment.
+1, we can pick it up from versions.props
There was a problem hiding this comment.
Addressed, please review the changes
| inputs: | ||
| command: 'custom' | ||
| arguments: 'install Microsoft.WindowsAppSDK -OutputDirectory $(packagesDir) -ConfigFile $(Build.SourcesDirectory)\nuget.config' | ||
| arguments: 'install Microsoft.WindowsAppSDK -Version 2.4.0 -DependencyVersion Lowest -OutputDirectory $(packagesDir) -ConfigFile $(Build.SourcesDirectory)\nuget.config -NonInteractive' |
There was a problem hiding this comment.
+1, we can pick it up from versions.props
| # The latest public release is resolved via the WinUI.Dependencies feed (which has nuget.org as an upstream) | ||
| # The package is installed into a temp directory to ensure it doesn't get used elsewhere for a build | ||
| # The pinned public release is installed into a temp directory to ensure it isn't used elsewhere for a build. | ||
| - task: NuGetCommand@2 |
There was a problem hiding this comment.
I am curious why this version update is needed? Did we introduce a dependency for static tests recently?
And even if we did, now that we are pulling it from private feed, shouldn't it already be available?
Preserve latest-version behavior by default while allowing static-test callers to select a specific version. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
It seems WinMDVerifyLCR thing is still not found. We need to redirect it to private dependencies. |
Make the protected WinUI dependencies feed URI available to the GitHub static-test stage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the native package download task and pass the verifier version directly to the compatibility script. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f090face-2019-4029-b63e-6bfaee25f47e
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
Summary
Fix GitHub static-test package restore and route the private WinMD verifier through the internal feed.
Changes
Microsoft.WindowsAppSDKto2.4.0.WinMDVersionVerifyLcr 1.0.2from internalWinUI.Dependenciesfor non-fork PRs.Validation
Microsoft.WindowsAppSDK 2.4.0using only shine-oss@Local.