Tabular: stable per-column header automation RuntimeIds - #11652
Draft
Hitesh Kumar (hiteshkrmsft) wants to merge 1 commit into
Draft
Tabular: stable per-column header automation RuntimeIds#11652Hitesh Kumar (hiteshkrmsft) wants to merge 1 commit into
Hitesh Kumar (hiteshkrmsft) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
added
the
needs-triage
…ay stable TableViewColumnHeaderAutomationPeer instances were created on demand, so a column's UIA RuntimeId changed across enumeration, reorder and virtualization. Cache the peer on TableViewColumn and hand the same instance back for the lifetime of the ownership. The cache is cleared when the column is detached from its TableView; the single-owner invariant in SetOwningTableViewInternal guarantees a re-own always passes through that detach, so a cached peer can never outlive its owner. Also drops the stale comments that documented the colliding-RuntimeId behaviour. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hitesh Kumar (hiteshkrmsft)
force-pushed
the
user/hik/tableview-column-runtimeids
branch
from
August 26, 2026 05:38
8cec237 to
e014b8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the TableView automation work out of the workaround-removal branch so it can be reviewed on its own. Draft on purpose - more automation changes are queued for this branch.
What this does
TableViewColumnHeaderAutomationPeerinstances were created on demand, so a column's UIARuntimeIdchanged across enumeration, reorder and virtualization. This caches the peer onTableViewColumnand returns the same instance for the lifetime of the ownership.The cache is cleared when the column is detached from its
TableView. The single-owner invariant inSetOwningTableViewInternalrejects a re-own that has not first passed through the detach path, so a cached peer can never outlive its owner.Also drops the comments that documented the old colliding-RuntimeId behaviour.
Why it is separate
Zero coupling with the workaround-removal work - 29 lines, all under
controls/dev/TableView/, no IDL, no build, no packaging, no resource changes. Different reviewers and a different test story, so it should not gate that branch.Not done yet