Cameronbaird/msft preview/factory static enlightenment#462
Draft
Camelron wants to merge 2 commits into
Draft
Conversation
Camelron
force-pushed
the
cameronbaird/msft-preview/factory-static-enlightenment
branch
from
718526d to
c0c7eb9
Compare
Author
|
This change is WIP. The config is wired up/adjusted at 5 or 6 different locations and it is difficult to make all paths robust. |
This patch is for the msft fork only. It wires up the static size configs such that factory respects the static_ fields. This means we have the same VM size model as is in production today: 1. With no limits specified, the user gets the static size 512Mi,1vcpu 2. With limits specified, the user gets the exact specified size which is limits.memory,limits.vcpus for the deployment Generated-By: Clause Opus 4.8 Signed-Off-By: Cameron Baird <cameronbaird@microsoft.com>
Camelron
force-pushed
the
cameronbaird/msft-preview/factory-static-enlightenment
branch
from
c0c7eb9 to
36cc885
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft.
This has two staged changes on top of the upstreamed clh-go templating support PR #461
End result is that we can have default_* configs = 0, static_resource_management=true, AND VM templating enabled. This means we get VM templating with no changes to our VM size model.
In the templating configuration we can restore from the default size (512Mi) and resize UP to match the deployment's required size. What we do lose is the ability to deploy with limits less than the default size (< 512Mi).