Fix controlled / uncontrolled state usage in components - #4206
Merged
Conversation
Anandraj (mganandraj)
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Most of the components were using a controlled pattern for state changes. As a result many of them were not interactive without conecting a handler for on-click that would chang the component state. In general this is fine for components that are part of a group which acts as a manager, but when the component is meant to be used as a standalone component this is problematic.
This standardizes and codefies the selection/checked patterns for components. It also fixes a few bugs and updates instructions for how to avoid those issues in the future.