Skip to content

Move Callout to use a primitive component pattern rather than being framework dependent - #4184

Merged
Jason Morse (JasonVMo) merged 3 commits into
mainfrom
user/jasonvmo/primitive-callout
Aug 13, 2026
Merged

Move Callout to use a primitive component pattern rather than being framework dependent#4184
Jason Morse (JasonVMo) merged 3 commits into
mainfrom
user/jasonvmo/primitive-callout

Conversation

@JasonVMo

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • all

Description of changes

These changes are in preparation for building fabric versions of Callout. There are two notable changes here:

Dedupe the macos version

The macos version was using FRNCallout instead of RCTCallout which is what other platforms used. This causes issues when you try to run it through codegen. A secondary issue is that macos variants can't be forked with platform suffixes because macos goes through the ios codegen pipeline and gets confused. The changes here are:

  • rename FRNCallout -> RCTCallout, checked OMR and talked to Saad and this should be fine
  • get rid of the macos specific version which differed only in default values. This can be handled in JS if necessary

Remove the old framework dependency

This component didn't need to be built with either framework, native components aren't really meant to be customized or composed, they should be somewhat dumb layers that are controlled by their callers.

  • removed the dependency on the frameworks
  • removed the custom adapters usage
  • removed unused dependencies
  • the callout will be transparent by default, styling can still be set as before or it can be dictated by the contents

Verification

Tests, manual inspection/debugging

Comment thread packages/components/Callout/src/Callout.types.ts
@JasonVMo
Jason Morse (JasonVMo) merged commit 0f2b987 into main Aug 13, 2026
14 checks passed
@JasonVMo
Jason Morse (JasonVMo) deleted the user/jasonvmo/primitive-callout branch August 13, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants