build: stop recording npm registry URLs in lockfiles - #349
Open
Jamie Magee (JamieMagee) wants to merge 1 commit into
Open
build: stop recording npm registry URLs in lockfiles#349Jamie Magee (JamieMagee) wants to merge 1 commit into
Jamie Magee (JamieMagee) wants to merge 1 commit into
Conversation
Add npm's omit-lockfile-registry-resolved setting to both frontend projects and remove registry URLs without changing dependency metadata. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates npm configuration for both frontends so package-lock.json files no longer record registry download URLs (e.g., Azure Artifacts feed URLs), reducing lockfile churn and preventing registry URL leakage while keeping lockfileVersion at 3.
Changes:
- Add
omit-lockfile-registry-resolved=truevia.npmrcinchat-app/frontendandscenario-app/frontend. - Remove all
resolvedregistry entries from bothpackage-lock.jsonfiles (dependency versions/integrity preserved).
Show a summary per file
| File | Description |
|---|---|
| chat-app/frontend/.npmrc | Enables omitting registry-resolved URLs in the chat frontend lockfile. |
| chat-app/frontend/package-lock.json | Removes resolved URL fields from the chat frontend lockfile while keeping lockfile v3. |
| scenario-app/frontend/.npmrc | Enables omitting registry-resolved URLs in the scenario frontend lockfile. |
| scenario-app/frontend/package-lock.json | Removes resolved URL fields from the scenario frontend lockfile while keeping lockfile v3. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/4 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
omit-lockfile-registry-resolved=trueinchat-app/frontendandscenario-app/frontend.resolvedfields from both lockfiles without changing dependency metadata or lockfile version 3.Does this introduce a breaking change?
How to Test
git clone https://github.com/JamieMagee/customer-chatbot-solution-accelerator.git cd customer-chatbot-solution-accelerator git checkout fix/omit-lockfile-registry-resolvedWhat to Check
Verify that the following are valid
npm config get omit-lockfile-registry-resolvedreturnstruein both frontend roots.Other Information