Skip to content

chore: update run_agents_script to get values from deployment - #330

Open
NirajC3-Microsoft wants to merge 1 commit into
devfrom
psl-update-agentcreationscript
Open

chore: update run_agents_script to get values from deployment#330
NirajC3-Microsoft wants to merge 1 commit into
devfrom
psl-update-agentcreationscript

Conversation

@NirajC3-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

This pull request improves the robustness of extracting the apiAppName value in both the PowerShell and Bash agent setup scripts. The changes add additional fallback mechanisms to handle variations in deployment output key names and ensure apiAppName is always set, even if the expected keys are missing.

Enhancements to deployment output extraction:

  • Added logic to check for alternative key names (chatApiAppName and CHAT_API_APP_NAME) if apiAppName is not found, increasing compatibility with AVM deployments. [1] [2]
  • Implemented a final fallback that derives apiAppName from solutionName using a standard naming convention if all other methods fail. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants