Skip to content

[main] Update dependencies from microsoft/dcp - #19527

Merged
David Negstad (danegsta) merged 1 commit into
mainfrom
darc-main-61840018-582d-46c6-b2cb-a4de8542d3a0
Aug 20, 2026
Merged

[main] Update dependencies from microsoft/dcp#19527
David Negstad (danegsta) merged 1 commit into
mainfrom
darc-main-61840018-582d-46c6-b2cb-a4de8542d3a0

Conversation

@dotnet-maestro

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/microsoft/dcp

  • Dependency Updates:
    • From 0.25.12 to 0.25.13
      • Microsoft.DeveloperControlPlane.darwin-amd64
      • Microsoft.DeveloperControlPlane.darwin-arm64
      • Microsoft.DeveloperControlPlane.linux-amd64
      • Microsoft.DeveloperControlPlane.linux-arm64
      • Microsoft.DeveloperControlPlane.linux-musl-amd64
      • Microsoft.DeveloperControlPlane.windows-amd64
      • Microsoft.DeveloperControlPlane.windows-arm64

On relative base path root
Microsoft.DeveloperControlPlane.darwin-amd64 , Microsoft.DeveloperControlPlane.darwin-arm64 , Microsoft.DeveloperControlPlane.linux-amd64 , Microsoft.DeveloperControlPlane.linux-arm64 , Microsoft.DeveloperControlPlane.linux-musl-amd64 , Microsoft.DeveloperControlPlane.windows-amd64 , Microsoft.DeveloperControlPlane.windows-arm64 From Version 0.25.12 -> To Version 0.25.13
Copilot AI balanced review requested due to automatic review settings August 20, 2026 02:40
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19527

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19527"

@github-actions github-actions Bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Aug 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates DCP runtime packages from 0.25.12 to 0.25.13 across all supported platforms.

Changes:

  • Bumps seven platform-specific DCP package versions.
  • Aligns dependency metadata with commit 8efd260c452d76d1d98cbf40ab58d8b4a7142ef0.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/Versions.props Updates DCP package versions.
eng/Version.Details.xml Updates DCP versions and source commit metadata.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

Tests selector (audit mode)

The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement.

Runs the full test matrix + all jobs (ALL) — a rule matching 'eng/Version.Details.xml' selects ALL


Selection computed for commit 9feef71.

@danegsta

Copy link
Copy Markdown
Member

PR Testing Report

PR Information

Artifact Version Verification

  • Expected Commit: 9feef71
  • Installed CLI: 13.6.0-pr.19527.g9feef713
  • DCP actually used at runtime: {"version":"0.25.13","commitHash":"8efd260c452d76d1d98cbf40ab58d8b4a7142ef0"}
  • Status: ✅ Verified

DCP 0.25.13 (8efd260) is the release/0.25 backport of microsoft/dcp#245"fix: reset inherited signal dispositions for forked processes on macOS".

Changes Analyzed

  • eng/Version.Details.xml — DCP 0.25.120.25.13
  • eng/Versions.props — DCP version properties 0.25.120.25.13

Dependency-flow only; no product code changes.

Background

On macOS, Go's setsig() installs SA_SIGINFO|SA_ONSTACK|SA_RESTART even when setting SIG_DFL. clearSignalHandlers() runs before execve, and execve preserves the flags, so a child launched by dcp fork-process starts with SIG_DFL handlers falsely advertising SA_SIGINFO. The .NET NativeAOT runtime saves the (NULL) sa_sigaction to chain to and calls it on the first SIGUSR1 GC suspension → SIGSEGV at 0x0.

Symptom: detached AppHost launches fail with AppHost process exited with code 255.

Test Scenarios Executed

Regression target: the two commands that launch the AppHost through dcp fork-process.

Scenario 0: Baseline (DCP 0.25.12, pre-PR) — control

Status: ✅ Reproduced (bug present, as expected)

Installed CLI 13.6.0-preview.1.26418.4 (DCP 0.25.12 / 622d6b8), aspire start on a polyglot TypeScript AppHost:

[warn] AppHostLauncher: Child CLI process exited with code 255
❌ AppHost process exited with code 255.

Fresh crash report aspire-2026-08-19-194756.ips:

EXC_BAD_ACCESS (SIGSEGV) / KERN_INVALID_ADDRESS at 0x0000000000000000

Scenario 1: aspire start (DCP 0.25.13)

Status: ✅ Passed

✅ AppHost started successfully.     (exit 0)
Name Type State Health URLs
app Executable Running Healthy http://localhost:62689
frontend Executable Running Healthy http://localhost:62688
  • curl frontend → HTTP 200; API → HTTP 404 (responding, no route at /)
  • aspire stop → clean, exit 0
  • No new crash report

Scenario 2: aspire run --detach (DCP 0.25.13)

Status: ✅ Passed

✅ AppHost started successfully.     (exit 0, PID 76606)
Name Type State Health URLs
app Executable Running Healthy http://localhost:54085
frontend Executable Running Healthy http://localhost:54086
  • aspire stop → clean, exit 0
  • No new crash report

Summary

Scenario Status Notes
0. Baseline on DCP 0.25.12 ✅ Reproduced Exit 255, SIGSEGV at 0x0 — control valid
1. aspire start on DCP 0.25.13 ✅ Passed Started, healthy, HTTP 200, clean stop, no crash
2. aspire run --detach on DCP 0.25.13 ✅ Passed Started, healthy, clean stop, no crash

Overall Result

✅ PR VERIFIED

The DCP 0.25.13 bump fixes the macOS exit-255 crash on detached AppHost launches. The failure reproduces reliably on 0.25.12 and both aspire start and aspire run --detach pass on 0.25.13.

Note (unrelated to this PR)

The underlying Go runtime behavior — Darwin setsig applying SA_SIGINFO|SA_ONSTACK|SA_RESTART to SIG_DFL before execve — affects any non-Go runtime launched through Go's os/exec on macOS, and is worth reporting upstream.

@danegsta

Copy link
Copy Markdown
Member

/backport to release/13.5

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/13.5 (link to workflow run)

@danegsta
David Negstad (danegsta) merged commit 8082614 into main Aug 20, 2026
753 of 759 checks passed
@danegsta
David Negstad (danegsta) deleted the darc-main-61840018-582d-46c6-b2cb-a4de8542d3a0 branch August 20, 2026 03:17
@github-actions github-actions Bot added this to the 13.6 milestone Aug 20, 2026
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

✅ No documentation update needed.

Step 5 branch taken: docs_optional → dependency_bump

  • recommendation was docs_optional with signal_count: 0 (no signals triggered).
  • Changed files: eng/Version.Details.xml and eng/Versions.props only — both are dependency manifest files updating the microsoft/dcp (Developer Control Plane) package versions from 0.25.12 to 0.25.13 for all platform RIDs (darwin, linux, windows amd64/arm64/musl).
  • This is a routine automated dependency bump (dotnet-maestro[bot]) with no behavior, API, CLI, or user-facing surface changes in this PR — purely a version pin update. Matches the dependency_bump allowlist category exactly (all 2 changed files match eng/Version.Details.xml / eng/Versions.props, no source or behavior changes accompany the bump).

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ CI Failure Analysis: Possible Flaky Test(s)

The CI build failed due to test failure(s) that appear unrelated to the PR changes. These may be flaky tests.

Suspected flaky test(s):

  • Aspire.Dashboard.Tests.Model.DashboardClientTests.SubscribeResources_ReplicaStateOwnedPropertyMetadataChanged_EmitsParentChange in job Tests / Dashboard / Dashboard (ubuntu-latest)
    • Error: Assert.True() Failure
      Expected: True
      Actual: False
    • Stack Trace (first frames):
      at Aspire.Dashboard.Tests.Model.DashboardClientTests.SubscribeResources_ReplicaStateOwnedPropertyMetadataChanged_EmitsParentChange() in /_/tests/Aspire.Dashboard.Tests/Model/DashboardClientTests.cs:line 740
      
    • Why likely flaky: PR only modifies eng/Version.Details.xml and eng/Versions.props (dependency updates), not DashboardClientTests.cs or the dashboard resource-change code it exercises. Other DashboardClientTests.SubscribeResources_* tests have repeatedly shown similar intermittent event-ordering/timing failures in this run history, indicating a pre-existing flaky test area rather than a code issue introduced by this PR.

Suggested actions:

  • Re-run the failed CI jobs to confirm if the failure is intermittent
  • If the test continues to fail, consider quarantining it using /quarantine-test <test name> <issue URL>
  • Search existing issues to see if this test is already known to be flaky

You can re-run the failed jobs from the workflow run page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-codeflow for labeling automated codeflow. intentionally a different color!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aspire start crashes TypeScript AppHosts on macOS after DCP fork-process launch

2 participants