Skip to content

Recommend Aspire.OpenAI for Foundry Local - #1707

Open
David Pine (IEvangelist) with Copilot wants to merge 11 commits into
mainfrom
copilot/update-azure-ai-foundry-docs
Open

Recommend Aspire.OpenAI for Foundry Local#1707
David Pine (IEvangelist) with Copilot wants to merge 11 commits into
mainfrom
copilot/update-azure-ai-foundry-docs

Conversation

Copilot AI commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Azure AI Foundry docs should lead C# Foundry Local users to Aspire.OpenAI, while retaining direct OpenAI SDK guidance for cloud resources that authenticate with managed identity.

  • Foundry connection guidance

    • Adds an Aspire.OpenAI C# example for Foundry Local.
    • Clarifies why the integration overrides the injected endpoint with the OpenAI-compatible openai/v1/ route.
    • Keeps direct OpenAI SDK examples for cloud-provisioned Foundry resources and Python, Go, and TypeScript.

  • Compatibility matrix

    • Marks Aspire.OpenAI as the preferred Foundry Local integration.
    • Marks Aspire.Azure.AI.Inference as legacy for Foundry.
    • Links matrix guidance to the canonical Foundry connection sample.
builder.AddOpenAIClient(
        "chat",
        settings =>
        {
            settings.Endpoint = new Uri(new Uri(endpoint), "openai/v1/");
            settings.Key = apiKey;
        })
    .AddChatClient();

Copilot AI and others added 9 commits September 21, 2026 18:51
@IEvangelist
docs: recommend Aspire.OpenAI for Foundry Local
188fe5f 
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
@IEvangelist
docs: clarify Foundry OpenAI samples
f865a3a 
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
@IEvangelist
docs: complete Foundry integration guidance
49c64cf 
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
@IEvangelist
docs: consolidate Foundry OpenAI samples
fa6f2e5 
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
@IEvangelist
docs: explain Foundry OpenAI configuration
4d93238 
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
@IEvangelist
docs: clarify Foundry integration flow
53da806 
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
@IEvangelist
docs: harden Foundry OpenAI sample
ae26cd7 
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
@IEvangelist
docs: link Foundry OpenAI guidance
27d6114 
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
@IEvangelist
docs: clarify Foundry OpenAI recommendations
564665b 
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
Copilot AI changed the title [WIP] Update Azure AI Foundry documentation for Aspire.OpenAI integration Recommend Aspire.OpenAI for Foundry Local Sep 21, 2026
@IEvangelist David Pine (IEvangelist) mentioned this pull request Sep 21, 2026
Merged
@aspire-repo-bot

aspire-repo-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Frontend HTML artifact ready

The latest frontend build uploaded the frontend-dist artifact for PR #1707. Use the VS Code button below to open this PR with GitHub Artifacts Explorer and browse the built HTML locally.

VS Code: Open PR #1707 artifacts

This comment updates automatically when a new frontend build artifact is uploaded.

Webmekanic
David Aniebo (Webmekanic) reviewed Sep 21, 2026
View reviewed changes
Comment thread ...tend/src/content/docs/integrations/cloud/azure/azure-ai-foundry/azure-ai-foundry-connect.mdx Outdated
Comment thread ...tend/src/content/docs/integrations/cloud/azure/azure-ai-foundry/azure-ai-foundry-connect.mdx Outdated
Comment thread ...tend/src/content/docs/integrations/cloud/azure/azure-ai-foundry/azure-ai-foundry-connect.mdx Outdated
@IEvangelist
Fix Foundry Local guidance and mobile consent handling
5e3e6d4 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@IEvangelist
David Pine (IEvangelist) marked this pull request as ready for review September 28, 2026 15:18
Copilot AI lite review requested due to automatic review settings September 28, 2026 15:18
Copilot AI reviewed Sep 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

A moderate helper regression and two documentation inconsistencies remain unresolved.

Review effort: Lite
Findings: 1 Medium severity · 1 Low severity

Open (2)
What changed in this PR

Updates Foundry Local guidance to recommend Aspire.OpenAI while retaining cloud OpenAI SDK guidance, and expands cookie-consent E2E coverage.

Changes:

  • Adds Foundry Local C# integration guidance.
  • Updates compatibility recommendations and connection examples.
  • Adds coverage for delayed and alternate cookie-consent banners.
File Summary
src/​frontend/​tests/​e2e/​helpers.ts Updates cookie dismissal behavior. Moderate (2 votes): restore tolerance for destroyed execution contexts.
src/​frontend/​tests/​e2e/​cookie-consent.spec.ts Adds consent-banner coverage; no final comment.
src/​frontend/​src/​content/​docs/​integrations/​cloud/​azure/​azure-ai-foundry/​azure-ai-foundry-get-started.mdx Updates Foundry connection guidance; no final comment.
src/​frontend/​src/​content/​docs/​integrations/​cloud/​azure/​azure-ai-foundry/​azure-ai-foundry-connect.mdx Adds Aspire.OpenAI guidance. Nit (3 votes): reconcile the documented endpoint and key with the local implementation.
src/​frontend/​src/​content/​docs/​integrations/​cloud/​azure/​ai-compatibility-matrix.mdx Updates integration recommendations. Nit (1 vote): distinguish local Model connection properties from Azure deployment properties.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/frontend/tests/e2e/helpers.ts
const rejectAllButton = page
.locator('#wcp-cookie-banner')
.getByRole('button', { name: /^reject(?: all)?$/i });
if (await rejectAllButton.isVisible()) {
Comment thread ...tend/src/content/docs/integrations/cloud/azure/azure-ai-foundry/azure-ai-foundry-connect.mdx
settings =>
{
ArgumentNullException.ThrowIfNull(settings.Endpoint);
settings.Endpoint = new Uri(settings.Endpoint, "v1/");
Webmekanic
David Aniebo (Webmekanic) approved these changes Sep 28, 2026
View reviewed changes

@Webmekanic David Aniebo (Webmekanic) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@IEvangelist David Pine (IEvangelist) Awaiting requested review from IEvangelist IEvangelist is a code owner
@eerhardt Eric Erhardt (eerhardt) Awaiting requested review from eerhardt eerhardt is a code owner
+1 more reviewer
@Webmekanic David Aniebo (Webmekanic) Webmekanic approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@IEvangelist David Pine (IEvangelist)

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IEvangelist @Webmekanic