.NET: test: add AgentResponse edge case coverage#5841
Open
challaravinath wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds targeted unit tests in the .NET Abstractions test suite to cover previously untested AgentResponse edge cases, improving confidence in response handling behavior without modifying production code.
Changes:
- Added a constructor guard test for
AgentResponse(ChatResponse)when passednull. - Added
Textbehavior tests for non-text-only content and forMessagesbeing set tonull. - Added a test ensuring
ToAgentResponseUpdates()preserves message ordering across multiple messages.
| public void Constructor_WithNullChatResponse_ThrowsArgumentNullException() | ||
| { | ||
| // Act & Assert | ||
| Assert.Throws<ArgumentNullException>(() => new AgentResponse((ChatResponse)null!)); |
lokitoth
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
AgentResponse had no tests covering null ChatResponse construction,
Text property behavior with non-text content, Text after Messages
is set to null, or message order preservation in ToAgentResponseUpdates.
These are gaps in critical response handling paths.
-->
Description
Contribution Checklist