Add WebUI env loading and backend preflight#63
Open
summerview1997 wants to merge 2 commits into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes WebUI training launches that silently miss local model endpoint
configuration.
The WebUI previously built the subprocess environment from
os.environplus.secrets/*.env, but did not load the repository-level.env. A user couldsuccessfully test a Qwen/OpenAI-compatible endpoint from the shell while the
WebUI subprocess fell back to defaults such as
http://localhost:8000/v1.Changes
PROJECT_ROOT/.envbefore.secrets/*.envwhen building the WebUItraining subprocess environment.
export KEY=valuesyntax in env files.launch.
openai_chatendpoints.qwen_chatbase URLs..envloading and backend preflight behavior.Impact
Users get an immediate actionable error before launch when a backend endpoint is
missing or unreachable, instead of a training run that appears to proceed while
all rollouts fail.
Validation
/home/thomas/SkillOpt/.venv/bin/python -m pytest -q tests/test_webui_env_preflight.py/home/thomas/SkillOpt/.venv/bin/python -m pytest -q/home/thomas/SkillOpt/.venv/bin/python -m ruff check skillopt_webui/app.py tests/test_webui_env_preflight.py/home/thomas/SkillOpt/.venv/bin/python -m py_compile skillopt_webui/app.py tests/test_webui_env_preflight.pygit diff --check