fix: Contact Center Scenario Displays Incorrect Dataset Title Instead of "Contact Center Dataset" - #1056
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves deployment/runtime resiliency by (1) changing Azure SQL initialization behavior to allow retries after transient failures and (2) adding a post-provision script gate that waits for backend SQL connectivity before attempting scenario registration/cleanup calls.
Changes:
- Update Azure SQL init logging to indicate failures will be retried on subsequent use.
- Add
Wait-ForBackendSqlHealthyto poll/api/healthuntil SQL is reachable before proceeding with data setup.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/api/storage/sql_service.py | Updates Azure SQL init failure handling/log messaging to support retry-on-next-use semantics. |
| infra/scripts/post-provision/setup-data.ps1 | Adds a SQL readiness wait/poll step against the backend deep health endpoint before scenario/data operations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Avijit-Microsoft
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces improvements to package management and deployment reliability across the project. The main changes are the enforcement of custom package registries for both Python and Node.js dependencies, enhancements to deployment scripts to ensure backend SQL readiness, and infrastructure template adjustments for improved resource deployment sequencing.
Package Management and Dependency Configuration:
--index-url https://packagefeedproxy.microsoft.io/pypi/simple/to all relevantrequirements.txtfiles and setting thePIP_INDEX_URLenvironment variable in GitHub Actions workflows (.github/workflows/deploy.yml,.github/workflows/job-test-automation.yml,.github/workflows/pylint.yml,.github/workflows/test-automation.yml,.github/workflows/test.yml,infra/scripts/post-provision/requirements.txt,infra/vscode_web/endpoint-requirements.txt,infra/vscode_web/requirements.txt,src/api/requirements.txt) [1] [2] [3] [4] [5] [6] [7] [8]..npmrc, Dockerfiles, and devcontainer settings (src/app/.npmrc,.devcontainer/Dockerfile,.devcontainer/devcontainer.json,src/app/WebApp.Dockerfile) [1] [2] [3] [4].Deployment and Reliability Enhancements:
setup-data.ps1to wait for backend SQL connectivity before proceeding with scenario registration, reducing race conditions during deployment.src/api/storage/sql_service.py).Infrastructure Template Updates:
virtualMachineAvailabilityZonefrom1to-1in Bicep and generated ARM templates, and adjusts resource dependency ordering for private DNS zones to ensure correct deployment sequencing (infra/avm/main.bicep,infra/avm/main.json,infra/main.json) [1] [2] [3] [4] [5].Dependency Updates:
PyYAMLversion insrc/api/requirements.txtfrom6.0.2to6.0.3.These changes ensure all environments and CI pipelines consistently use the organization's package feeds, improve deployment robustness, and address minor dependency and infrastructure issues.
BUG ID : https://dev.azure.com/CSACTOSOL/CSA%20Solutioning/_workitems/edit/50875/
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information