feat: add .golangci.yml linter configuration by Sefi4 · Pull Request #83 · micromize-dev/micromize

Sefi4 · 2026-02-25T20:35:39Z

Summary

Adds a .golangci.yml configuration file with sensible defaults and fixes all existing lint issues.

Changes

New: `.golangci.yml` (golangci-lint v2)

Linters: errcheck, errorlint, govet, ineffassign, gosec, staticcheck, unused
Formatters: gofmt, goimports (with local-prefixes for github.com/micromize-dev/micromize)
Exclusions: build/ directory, ST1000/ST1003 staticcheck rules, G115 gosec rule
Timeout: 5 minutes

New Makefile targets

make lint — runs golangci-lint run ./...
make fmt — runs gofmt -w .
make vet — runs go vet ./...
make clean — removes build artifacts

Lint fixes

internal/operators/operators.go: check host.Init() error return
internal/runtime/manager.go: check runtime.Close() error return
cmd/micromize/root.go: fix import ordering (goimports)
internal/utils/utils_test.go: use 0600 file permissions (gosec G306)
internal/utils/utils.go: remove trailing message from error string (staticcheck ST1005)

Closes #45
Closes #46
Closes #49 (completion of the work started in #85)

Copilot

Pull request overview

This pull request adds golangci-lint configuration to establish automated code quality checks for the micromize project. It introduces a .golangci.yml file with linter settings, adds corresponding Makefile targets for linting and formatting, and fixes existing code issues identified by the linters.

Changes:

New .golangci.yml configuration file with 7 enabled linters and exclusion rules
New Makefile targets: lint, fmt, vet, and clean
Fixed 5 existing lint issues across 4 files: error handling, import ordering, file permissions, and error messages

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`.golangci.yml`	New golangci-lint v2 configuration with linters, settings, and exclusions
`Makefile`	Added lint, fmt, vet, and clean targets for code quality automation
`internal/operators/operators.go`	Added error handling for `host.Init()` call
`internal/runtime/manager.go`	Added error checking and logging for `runtime.Close()`
`cmd/micromize/root.go`	Fixed import ordering to separate stdlib, external, and local imports
`internal/utils/utils_test.go`	Changed temp file permissions from 0644 to 0600 for security
`internal/utils/utils.go`	Removed trailing message from error string per staticcheck ST1005

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sefi4

Thank you for the review! However, all four comments appear to be based on the golangci-lint v1 configuration format. This config uses version: "2" (line 1), which has a significantly different schema.

In golangci-lint v2:

linters.settings is the correct location for linter-specific settings (not top-level linters-settings)
linters.exclusions replaces the old issues.exclude-rules for linter exclusions
formatters is a new top-level section that separates formatting tools (gofmt, goimports) from analysis linters
gosimple is included in staticcheck (which is already enabled) — it's not a separate linter in v2

Verification:

$ golangci-lint version
golangci-lint has version 2.10.1

$ golangci-lint config verify -v
INFO Verifying the configuration file ".golangci.yml" with the JSON Schema from https://golangci-lint.run/jsonschema/golangci.v2.10.jsonschema.json
(exit 0 — no errors)

$ golangci-lint run ./...
0 issues.

Reference: https://golangci-lint.run/docs/configuration/#version-2

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dorser

Can you change the commit message verb from "feat" to "chore"?
After that I think we can merge 👍

dorser · 2026-02-27T16:05:49Z

+        with:
+          # This version number must be kept in sync with Makefile lint one.
+          version: v2.10.1
+          working-directory: /home/runner/work/inspektor-gadget/inspektor-gadget


This is probably why the build is failing

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-28T09:12:16Z


 	writeConfig := func(image string) {
 		cfg := map[string]any{"Config": map[string]string{"Image": image}}
 		data, _ := json.Marshal(cfg)


In this test helper, json.Marshal’s error is discarded (data, _ := json.Marshal(cfg)). With errcheck enabled in this PR, ignoring marshal errors is likely to be reported (and it also hides unexpected failures). Please handle the marshal error (e.g., fail the test) instead of assigning it to _.

Suggested change

data, _ := json.Marshal(cfg)

data, err := json.Marshal(cfg)

if err != nil {

t.Fatal(err)

}

Copilot · 2026-02-28T09:12:17Z

+# E2E Integration Tests for PR #93 — Digest-Based BPF Map Sharing
+
+Manual test scenarios for validating the functionality introduced in
+[PR #93](https://github.com/micromize-dev/micromize/pull/93) which resolves
+[Issue #91](https://github.com/micromize-dev/micromize/issues/91).
+


This new document is titled for PR #93 and references a personal branch/registry (e.g. sefitufan/..., sefiacr.azurecr.io), which doesn’t appear related to this PR’s stated goal (adding golangci-lint config + lint fixes). Consider moving this to the PR that introduced digest-based map sharing, or relocating it under docs/ with project-generic placeholders so it doesn’t bake in contributor-specific environment details.

- Add golangci-lint v2 configuration with linters: errcheck, errorlint, govet, ineffassign, gosec, staticcheck, unused - Add formatters: gofmt, goimports with local-prefixes - Exclude build/ directory and suppress ST1000/ST1003 staticcheck rules - Add lint, fmt, vet, clean Makefile targets - Fix errcheck: check host.Init() and runtime.Close() return values - Fix goimports: reorder imports in root.go - Fix gosec G306: use 0600 file permissions in test - Fix staticcheck ST1005: remove trailing message from error string Closes micromize-dev#45 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Sefi Tufan <sefitufan@microsoft.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-28T10:25:37Z

+
+	"github.com/go-jose/go-jose/v4/testutils/require"


internal/sbom/sbom_test.go adds a dependency on github.com/go-jose/go-jose/v4/testutils/require. This is a testutils package from an unrelated module and generally not intended as a stable external test assertion library; it also forces adding go-jose as a direct module dependency for a single NoError call. Prefer using standard testing checks (or an existing/common assertion library in this repo) to avoid the extra dependency and potential future breakage.

Suggested change

"github.com/go-jose/go-jose/v4/testutils/require"

this is unrelated to this PR. I'll fix it in a follow-up PR

Copilot · 2026-02-28T10:25:37Z

 require (
+	github.com/cilium/ebpf v0.20.0
+	github.com/cyphar/filepath-securejoin v0.5.1
+	github.com/docker/cli v29.2.0+incompatible
+	github.com/go-jose/go-jose/v4 v4.1.3
 	github.com/inspektor-gadget/inspektor-gadget v0.49.1
+	github.com/opencontainers/image-spec v1.1.1
 	github.com/quay/claircore v1.5.45
 	github.com/sirupsen/logrus v1.9.4
 	github.com/spf13/cobra v1.10.2
+	golang.org/x/sync v0.19.0


go.mod adds github.com/go-jose/go-jose/v4 as a direct dependency, but the only in-repo usage appears to be go-jose/v4/testutils/require in internal/sbom/sbom_test.go. Consider removing this dependency (or replacing it with standard testing assertions / a project-standard assertion lib) so the main module dependency set isn’t expanded just to support a single test helper.

Copilot AI review requested due to automatic review settings February 25, 2026 20:35

Copilot started reviewing on behalf of Sefi4 February 25, 2026 20:36 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

Comment thread .golangci.yml

Comment thread .golangci.yml

Comment thread .golangci.yml

Comment thread .golangci.yml

Sefi4 commented Feb 25, 2026

View reviewed changes

Sefi4 force-pushed the sefitufan/add-golangci-lint-config branch from f4f8128 to e2bf6e4 Compare February 25, 2026 21:23

dorser reviewed Feb 26, 2026

View reviewed changes

Comment thread Makefile Outdated

Comment thread Makefile Outdated

Copilot AI review requested due to automatic review settings February 27, 2026 09:42

Sefi4 force-pushed the sefitufan/add-golangci-lint-config branch from e2bf6e4 to 0b7933c Compare February 27, 2026 09:42

Copilot started reviewing on behalf of Sefi4 February 27, 2026 09:43 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

Comment thread Makefile

Comment thread Dockerfiles/linter.Dockerfile Outdated

Sefi4 force-pushed the sefitufan/add-golangci-lint-config branch from 0b7933c to f11e34a Compare February 27, 2026 09:54

dorser reviewed Feb 27, 2026

View reviewed changes

Sefi4 force-pushed the sefitufan/add-golangci-lint-config branch from f11e34a to a9b03db Compare February 27, 2026 16:43

Copilot AI review requested due to automatic review settings February 27, 2026 16:43

Copilot started reviewing on behalf of Sefi4 February 27, 2026 16:44 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

Comment thread .golangci.yml Outdated

Comment thread Makefile

Comment thread Makefile

Comment thread internal/utils/utils.go Outdated

Sefi4 force-pushed the sefitufan/add-golangci-lint-config branch from a9b03db to 35373f7 Compare February 27, 2026 17:54

Copilot AI review requested due to automatic review settings February 28, 2026 09:07

Sefi4 force-pushed the sefitufan/add-golangci-lint-config branch from 35373f7 to 9d2ae2e Compare February 28, 2026 09:07

Copilot started reviewing on behalf of Sefi4 February 28, 2026 09:07 View session

Sefi4 force-pushed the sefitufan/add-golangci-lint-config branch from 9d2ae2e to 3b08a2b Compare February 28, 2026 09:08

Sefi4 requested a review from dorser February 28, 2026 09:09

Copilot AI reviewed Feb 28, 2026

View reviewed changes

Sefi4 force-pushed the sefitufan/add-golangci-lint-config branch from 3b08a2b to aaeb408 Compare February 28, 2026 10:17

Sefi4 force-pushed the sefitufan/add-golangci-lint-config branch from aaeb408 to 162fc00 Compare February 28, 2026 10:20

Copilot AI review requested due to automatic review settings February 28, 2026 10:20

Copilot started reviewing on behalf of Sefi4 February 28, 2026 10:21 View session

Copilot AI reviewed Feb 28, 2026

View reviewed changes

dorser merged commit 945ebe4 into micromize-dev:main Mar 1, 2026
9 of 10 checks passed

-		data, _ := json.Marshal(cfg)
+		data, err := json.Marshal(cfg)
+		if err != nil {
+			t.Fatal(err)
+		}

Conversation

Sefi4 commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

New: .golangci.yml (golangci-lint v2)

New Makefile targets

Lint fixes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sefi4 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

dorser left a comment

Choose a reason for hiding this comment

Uh oh!

dorser Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Sefi4 Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

dorser Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Sefi4 commented Feb 25, 2026 •

edited

Loading

New: `.golangci.yml` (golangci-lint v2)